Attention is currently required from: Nick Vaccaro, Sheng-Liang Pan, YH Lin.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55113 )
Change subject: mb/google/volteer/var/volet: Update gpio and devicetree settings
......................................................................
Patch Set 2:
(3 comments)
File src/mainboard/google/volteer/variants/volet/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/55113/comment/4afd1b00_eadcae1e
PS2, Line 26: device i2c 1a on
: end
nit:
`device i2c 1a on end`
https://review.coreboot.org/c/coreboot/+/55113/comment/d78ac3bb_11478475
PS2, Line 44: device i2c 32 on
: end
```
device i2c 32 on
end
```
https://review.coreboot.org/c/coreboot/+/55113/comment/50c9af5a_8a9090cb
PS2, Line 112: 0x2c
Please be consistent with i2c address formats:
`2c`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55113
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0e9557e01ce1e7a49a3dddf6da3e4a29587a8b7
Gerrit-Change-Number: 55113
Gerrit-PatchSet: 2
Gerrit-Owner: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@chromium.org
Gerrit-Comment-Date: Tue, 01 Jun 2021 20:15:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment