Attention is currently required from: Ravi kumar, Martin Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52371 )
Change subject: sc7280: Add GSI FW download support ......................................................................
Patch Set 4:
(11 comments)
File src/soc/qualcomm/sc7280/include/soc/qupv3_config.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117959): https://review.coreboot.org/c/coreboot/+/52371/comment/6e34aa83_db1b1bc6 PS4, Line 77: { open brace '{' following struct go on the same line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117959): https://review.coreboot.org/c/coreboot/+/52371/comment/f346c9f6_0cc9da16 PS4, Line 79: uint32_t iram_dword1; /* word 1 of a single IRAM firmware entry */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117959): https://review.coreboot.org/c/coreboot/+/52371/comment/de79dccc_1c34022b PS4, Line 83: { open brace '{' following struct go on the same line
File src/soc/qualcomm/sc7280/qupv3_config.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117959): https://review.coreboot.org/c/coreboot/+/52371/comment/ed4c1147_9b9d4cdd PS4, Line 204: write32(®s->gsi_periph_base_lsb,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117959): https://review.coreboot.org/c/coreboot/+/52371/comment/e8b0852e_40e9e201 PS4, Line 205: write32(®s->gsi_periph_base_msb,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117959): https://review.coreboot.org/c/coreboot/+/52371/comment/7ea3f8dd_7465461a PS4, Line 210: if (fwIep[i].offset < GSI_REG_BASE_SIZE) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117959): https://review.coreboot.org/c/coreboot/+/52371/comment/d7664948_94e43995 PS4, Line 221: memcpy((®s->gsi_inst_ramn),(void *)fwIRam, space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117959): https://review.coreboot.org/c/coreboot/+/52371/comment/04ec83a6_3af82718 PS4, Line 223: setbits_le32(®s->gsi_mcs_cfg, GSI_MCS_CFG_MCS_ENABLE_BMSK ); space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117959): https://review.coreboot.org/c/coreboot/+/52371/comment/33a8f5f2_88015834 PS4, Line 224: setbits_le32(®s->gsi_cfg, GSI_CFG_DOUBLE_MCS_CLK_FREQ_BMSK | GSI_CFG_GSI_ENABLE_BMSK); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117959): https://review.coreboot.org/c/coreboot/+/52371/comment/22cd0127_5359661c PS4, Line 226: write32(®s->gsi_ee_n_scratch_0_addr,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117959): https://review.coreboot.org/c/coreboot/+/52371/comment/d03950b3_3e2f6f44 PS4, Line 227: write32(®s->ee_n_gsi_ee_generic_cmd,0x81); space required after that ',' (ctx:VxV)