Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44878 )
Change subject: util/spd_tools: output binaries instead of hexdumps ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/44878/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44878/3//COMMIT_MSG@10 PS3, Line 10: file ending minor nit: I'd call this `file extension`. At first, I confused this with `line ending`, a completely different thing.
https://review.coreboot.org/c/coreboot/+/44878/3/util/spd_tools/ddr4/gen_spd... File util/spd_tools/ddr4/gen_spd.go:
https://review.coreboot.org/c/coreboot/+/44878/3/util/spd_tools/ddr4/gen_spd... PS3, Line 972: bytes.Buffer Probably not for this patch, but is there a way to tell Go this buffer is supposed to be 512 (or whatever) bytes in size?
-
Angel Pons (Code Review)