Prudhvi Yarlagadda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29957 )
Change subject: libpayload: Add UART for qcs405
......................................................................
Patch Set 26:
(1 comment)
https://review.coreboot.org/#/c/29957/20/payloads/libpayload/drivers/serial/...
File payloads/libpayload/drivers/serial/qcs405.c:
https://review.coreboot.org/#/c/29957/20/payloads/libpayload/drivers/serial/...
PS20, Line 544: /* For simplicity sake let's rely on coreboot initalizing the UART. */
Thanks ! we will release the remaining changes and continue to debug the current issue.
We have identified that uart rx command registers are getting reset at the end of coreboot stage due to which we are facing issues if we remove the initialization here.
Please let us know if we can go ahead by initializing only the UART rx command registers or do the complete UART initialization as it is there at present?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29957
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43164cf9eacc844af1d048f7b6ebbda96fc9d202
Gerrit-Change-Number: 29957
Gerrit-PatchSet: 26
Gerrit-Owner: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Mukesh Savaliya
msavaliy@qualcomm.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Prudhvi Yarlagadda
pyarlaga@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Tue, 11 Jun 2019 13:19:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Prudhvi Yarlagadda
pyarlaga@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment