Attention is currently required from: David Hendricks, Jonathan Zhang, Shuo Liu, TangYiwei.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81321?usp=email )
Change subject: intel/common/block: Use fixed BDF for IBL
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81321/comment/aeddf57c_1128ee69 :
PS1, Line 9: IBL codes doesn't support bootloader controlled P2SB hidden and
: unhidden.
What does this mean? Is there even a P2SB? If you cannot use P2SB code because of that you should simply not use this code rather than leaking awkward soc specific details in the common code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81321?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3975cb00e215c4984c63bb8510e8aef7d4cc85a4
Gerrit-Change-Number: 81321
Gerrit-PatchSet: 1
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: TangYiwei
Gerrit-Comment-Date: Sun, 17 Mar 2024 13:29:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment