Change in ...coreboot[master]: soc/intel/cannonlake: Add whitespace proper in CPU/MCH/IGD name
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31547
Change subject: soc/intel/cannonlake: Add whitespace proper in CPU/MCH/IGD name ......................................................................
soc/intel/cannonlake: Add whitespace proper in CPU/MCH/IGD name
Change-Id: I33a50e9fc90162c7cb2aa7fbc3887efe9c6ebcde Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/cannonlake/bootblock/report_platform.c 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/31547/1
diff --git a/src/soc/intel/cannonlake/bootblock/report_platform.c b/src/soc/intel/cannonlake/bootblock/report_platform.c index e61c7f4..b8b467f 100644 --- a/src/soc/intel/cannonlake/bootblock/report_platform.c +++ b/src/soc/intel/cannonlake/bootblock/report_platform.c @@ -37,8 +37,8 @@ { CPUID_CANNONLAKE_C0, "Cannonlake C0" }, { CPUID_CANNONLAKE_D0, "Cannonlake D0" }, { CPUID_COFFEELAKE_D0, "Coffeelake D0" }, - { CPUID_WHISKEYLAKE_V0, "Whiskeylake V0"}, - { CPUID_WHISKEYLAKE_W0, "Whiskeylake W0"}, + { CPUID_WHISKEYLAKE_V0, "Whiskeylake V0" }, + { CPUID_WHISKEYLAKE_W0, "Whiskeylake W0" }, { CPUID_COFFEELAKE_U0, "Coffeelake U0 (6+2)" }, };
@@ -49,8 +49,8 @@ { PCI_DEVICE_ID_INTEL_CNL_ID_U, "Cannonlake-U" }, { PCI_DEVICE_ID_INTEL_CNL_ID_Y, "Cannonlake-Y" }, { PCI_DEVICE_ID_INTEL_CFL_ID_U, "Coffeelake U (4+3e)"}, - { PCI_DEVICE_ID_INTEL_WHL_ID_Wx4, "Whiskeylake W (4+2)"}, - { PCI_DEVICE_ID_INTEL_WHL_ID_Wx2, "Whiskeylake W (2+2)"}, + { PCI_DEVICE_ID_INTEL_WHL_ID_Wx4, "Whiskeylake W (4+2)" }, + { PCI_DEVICE_ID_INTEL_WHL_ID_Wx2, "Whiskeylake W (2+2)" }, { PCI_DEVICE_ID_INTEL_CFL_ID_H, "Coffeelake-H" }, { PCI_DEVICE_ID_INTEL_CFL_ID_S, "Coffeelake-S" }, }; @@ -78,8 +78,8 @@ { PCI_DEVICE_ID_INTEL_CNL_GT2_ULT_2, "Cannonlake ULT GT1.5" }, { PCI_DEVICE_ID_INTEL_CNL_GT2_ULT_3, "Cannonlake ULT GT1" }, { PCI_DEVICE_ID_INTEL_CNL_GT2_ULT_4, "Cannonlake ULT GT0.5" }, - { PCI_DEVICE_ID_INTEL_CFL_GT2_ULT, "Coffeelake ULT GT2"}, - { PCI_DEVICE_ID_INTEL_WHL_GT2_ULT_1, "Whiskeylake ULT GT1"}, + { PCI_DEVICE_ID_INTEL_CFL_GT2_ULT, "Coffeelake ULT GT2" }, + { PCI_DEVICE_ID_INTEL_WHL_GT2_ULT_1, "Whiskeylake ULT GT1" }, { PCI_DEVICE_ID_INTEL_CFL_H_GT2, "Coffeelake-H GT2" }, { PCI_DEVICE_ID_INTEL_CFL_S_GT2, "Coffeelake-S GT2" }, };
Subrata Banik has removed build bot (Jenkins) from this change. ( https://review.coreboot.org/c/coreboot/+/31547 )
Change subject: soc/intel/cannonlake: Add whitespace proper in CPU/MCH/IGD name ......................................................................
Removed reviewer build bot (Jenkins) with the following votes:
* Verified+1 by build bot (Jenkins) no-reply@coreboot.org
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31547 )
Change subject: soc/intel/cannonlake: Add whitespace proper in CPU/MCH/IGD name ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31547 )
Change subject: soc/intel/cannonlake: Add whitespace proper in CPU/MCH/IGD name ......................................................................
Patch Set 1: Code-Review+1
Subrata Banik has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31547 )
Change subject: soc/intel/cannonlake: Add whitespace proper in CPU/MCH/IGD name ......................................................................
soc/intel/cannonlake: Add whitespace proper in CPU/MCH/IGD name
Change-Id: I33a50e9fc90162c7cb2aa7fbc3887efe9c6ebcde Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/31547 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aamir Bohra aamir.bohra@intel.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/soc/intel/cannonlake/bootblock/report_platform.c 1 file changed, 6 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Aamir Bohra: Looks good to me, approved
diff --git a/src/soc/intel/cannonlake/bootblock/report_platform.c b/src/soc/intel/cannonlake/bootblock/report_platform.c index e61c7f4..b8b467f 100644 --- a/src/soc/intel/cannonlake/bootblock/report_platform.c +++ b/src/soc/intel/cannonlake/bootblock/report_platform.c @@ -37,8 +37,8 @@ { CPUID_CANNONLAKE_C0, "Cannonlake C0" }, { CPUID_CANNONLAKE_D0, "Cannonlake D0" }, { CPUID_COFFEELAKE_D0, "Coffeelake D0" }, - { CPUID_WHISKEYLAKE_V0, "Whiskeylake V0"}, - { CPUID_WHISKEYLAKE_W0, "Whiskeylake W0"}, + { CPUID_WHISKEYLAKE_V0, "Whiskeylake V0" }, + { CPUID_WHISKEYLAKE_W0, "Whiskeylake W0" }, { CPUID_COFFEELAKE_U0, "Coffeelake U0 (6+2)" }, };
@@ -49,8 +49,8 @@ { PCI_DEVICE_ID_INTEL_CNL_ID_U, "Cannonlake-U" }, { PCI_DEVICE_ID_INTEL_CNL_ID_Y, "Cannonlake-Y" }, { PCI_DEVICE_ID_INTEL_CFL_ID_U, "Coffeelake U (4+3e)"}, - { PCI_DEVICE_ID_INTEL_WHL_ID_Wx4, "Whiskeylake W (4+2)"}, - { PCI_DEVICE_ID_INTEL_WHL_ID_Wx2, "Whiskeylake W (2+2)"}, + { PCI_DEVICE_ID_INTEL_WHL_ID_Wx4, "Whiskeylake W (4+2)" }, + { PCI_DEVICE_ID_INTEL_WHL_ID_Wx2, "Whiskeylake W (2+2)" }, { PCI_DEVICE_ID_INTEL_CFL_ID_H, "Coffeelake-H" }, { PCI_DEVICE_ID_INTEL_CFL_ID_S, "Coffeelake-S" }, }; @@ -78,8 +78,8 @@ { PCI_DEVICE_ID_INTEL_CNL_GT2_ULT_2, "Cannonlake ULT GT1.5" }, { PCI_DEVICE_ID_INTEL_CNL_GT2_ULT_3, "Cannonlake ULT GT1" }, { PCI_DEVICE_ID_INTEL_CNL_GT2_ULT_4, "Cannonlake ULT GT0.5" }, - { PCI_DEVICE_ID_INTEL_CFL_GT2_ULT, "Coffeelake ULT GT2"}, - { PCI_DEVICE_ID_INTEL_WHL_GT2_ULT_1, "Whiskeylake ULT GT1"}, + { PCI_DEVICE_ID_INTEL_CFL_GT2_ULT, "Coffeelake ULT GT2" }, + { PCI_DEVICE_ID_INTEL_WHL_GT2_ULT_1, "Whiskeylake ULT GT1" }, { PCI_DEVICE_ID_INTEL_CFL_H_GT2, "Coffeelake-H GT2" }, { PCI_DEVICE_ID_INTEL_CFL_S_GT2, "Coffeelake-S GT2" }, };
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31547 )
Change subject: soc/intel/cannonlake: Add whitespace proper in CPU/MCH/IGD name ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31547/2/src/soc/intel/cannonlake/bootblock/r... File src/soc/intel/cannonlake/bootblock/report_platform.c:
https://review.coreboot.org/#/c/31547/2/src/soc/intel/cannonlake/bootblock/r... PS2, Line 51: "} and this one ?
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31547 )
Change subject: soc/intel/cannonlake: Add whitespace proper in CPU/MCH/IGD name ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31547/2/src/soc/intel/cannonlake/bootblock/r... File src/soc/intel/cannonlake/bootblock/report_platform.c:
https://review.coreboot.org/#/c/31547/2/src/soc/intel/cannonlake/bootblock/r... PS2, Line 51: "}
and this one ?
oops. i thought i grepped everything. will fix it soon.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31547 )
Change subject: soc/intel/cannonlake: Add whitespace proper in CPU/MCH/IGD name ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31547/2/src/soc/intel/cannonlake/bootblock/r... File src/soc/intel/cannonlake/bootblock/report_platform.c:
https://review.coreboot.org/#/c/31547/2/src/soc/intel/cannonlake/bootblock/r... PS2, Line 51: "}
oops. i thought i grepped everything. will fix it soon.
https://review.coreboot.org/#/c/coreboot/+/31563/ please review.
-
Aamir Bohra (Code Review) -
HAOUAS Elyes (Code Review)
-
Paul Menzel (Code Review)
-
Subrata Banik (Code Review)