Attention is currently required from: Felix Held, Paul Menzel.
Brandon Weeks has posted comments on this change by Brandon Weeks. ( https://review.coreboot.org/c/coreboot/+/86260?usp=email )
Change subject: mb/cwwk/adl: Fix HDMI, PCIe CLKREQ, EC, TPM ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86260/comment/37ac84a6_65e415d3?usp... : PS2, Line 7: Various device tree fixes
Please make it a statement.
Done
https://review.coreboot.org/c/coreboot/+/86260/comment/91fb5d56_e16c787c?usp... : PS2, Line 9: - Set pmc_gpe0_dw{0-3} to resolve a warning
Please paste the warning.
Done
https://review.coreboot.org/c/coreboot/+/86260/comment/b20903c6_49004d65?usp... : PS2, Line 10: vendor firmware
Please add the version.
I don't think the vendor firmware has meaningful versions. It has never been updated after shipping, I'm working off the firmware dumped from flash.
https://review.coreboot.org/c/coreboot/+/86260/comment/b6381f99_e72a259d?usp... : PS2, Line 9: - Set pmc_gpe0_dw{0-3} to resolve a warning : - Set CLKREQ# based on register value from vendor firmware : - Enable ITE environment controller
Listing changes is always an indicator to make a separate commit per item. […]
Happy to break it up if the reviewer would prefer, however I suspect that would be a lot of churn given how much was broken on the board.