Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41060 )
Change subject: mb/google/dedede: [TEST-ONLY ]Enable S0ix support ......................................................................
mb/google/dedede: [TEST-ONLY ]Enable S0ix support
Change-Id: I4cadfe69e36f959b54e374800c32629a7481ea94 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/41060/1
diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb index cfe221f..af2fd17 100644 --- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -114,6 +114,9 @@ # Enable EMMC HS400 mode register "ScsEmmcHs400Enabled" = "1"
+ # Enable S0ix support + register "s0ix_enable" = "1" + # Display related UPDs # Select eDP for port A register "DdiPortAConfig" = "1"
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41060
to look at the new patch set (#3).
Change subject: mb/google/dedede: Enable S0ix support ......................................................................
mb/google/dedede: Enable S0ix support
Change-Id: I4cadfe69e36f959b54e374800c32629a7481ea94 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/41060/3
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41060
to look at the new patch set (#6).
Change subject: mb/google/dedede: Enable S0ix support ......................................................................
mb/google/dedede: Enable S0ix support
Change-Id: I4cadfe69e36f959b54e374800c32629a7481ea94 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/41060/6
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41060 )
Change subject: mb/google/dedede: Enable S0ix support ......................................................................
Patch Set 6: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41060 )
Change subject: mb/google/dedede: Enable S0ix support ......................................................................
mb/google/dedede: Enable S0ix support
Change-Id: I4cadfe69e36f959b54e374800c32629a7481ea94 Signed-off-by: Aamir Bohra aamir.bohra@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41060 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb index 0b69f7d..8b68beb 100644 --- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -119,6 +119,9 @@ # SD card power enable polarity register "SdCardPowerEnableActiveHigh" = "1"
+ # Enable S0ix support + register "s0ix_enable" = "1" + # Display related UPDs # Select eDP for port A register "DdiPortAConfig" = "1"
-
Aamir Bohra (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Patrick Georgi (Code Review)