Change in coreboot[master]: mb/google/dedede/var/waddledee: Enable GPIO based I2C Multiplexer
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45912 )
Change subject: mb/google/dedede/var/waddledee: Enable GPIO based I2C Multiplexer ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45912/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45912/8//COMMIT_MSG@9 PS8, Line 9:
an
Done
https://review.coreboot.org/c/coreboot/+/45912/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45912/8/src/mainboard/google/dedede... PS8, Line 125: ACPI_GPIO_OUTPUT_ACTIVE_HIGH
I think this should be just ACPI_GPIO_OUTPUT. Polarity doesn't really mean anything here.
Agree. Also the polarity settings of ACPI_GPIO_OUTPUT and ACPI_GPIO_OUTPUT_ACTIVE_HIGH are same.
-
Karthik Ramasubramanian (Code Review)