build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29470 )
Change subject: src/mainboard/portwell/m107: Do initial mainboard commit ......................................................................
Patch Set 2:
(10 comments)
https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/irqroute... File src/mainboard/portwell/m107/irqroute.h:
https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/irqroute... PS2, Line 23: IR02h GFX INT(A) - PIRQ A please, no space before tabs
https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/irqroute... PS2, Line 25: IR11h SDIO INT(A) - PIRQ B please, no space before tabs
https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/irqroute... PS2, Line 26: IR12h SD INT(A) - PIRQ C please, no space before tabs
https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/irqroute... PS2, Line 27: IR13h SATA INT(A) - PIRQ D please, no space before tabs
https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/irqroute... PS2, Line 28: IR14h XHCI INT(A) - PIRQ E please, no space before tabs
https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/irqroute... PS2, Line 29: IR15h LP Audio INT(A) - PIRQ F please, no space before tabs
https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/irqroute... PS2, Line 30: IR17h MMC INT(A) - PIRQ F please, no space before tabs
https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/irqroute... PS2, Line 39: #define PCI_DEV_PIRQ_ROUTES \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/spd/SAMS... File src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex:
https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/spd/SAMS... PS2, Line 187: 00 trailing whitespace
https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/spd/SAMS... PS2, Line 218: 00 00 00 00 trailing whitespace
-
build bot (Jenkins) (Code Review)