Attention is currently required from: Ben Kao, Karthik Ramasubramanian.
zanxi chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55385 )
Change subject: mb/google/dedede/var/blipper: Update devicetree and gpio setting
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/dedede/variants/blipper/gpio.c:
https://review.coreboot.org/c/coreboot/+/55385/comment/eb004781_59f47c3f
PS1, Line 9: static const struct pad_config gpio_table[] = {
1.Done. WWAN related pins that not been closed in baseboard have been all closed. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55385
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib5999f0e129bf3e660fe293eda7af3e8e1426151
Gerrit-Change-Number: 55385
Gerrit-PatchSet: 2
Gerrit-Owner: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ben Kao
ben.kao@intel.com
Gerrit-CC: Ginger Zhang
zhangqingchun@huaqin.corp-partner.google.com
Gerrit-CC: Krystal Han
hanlijing@huaqin.corp-partner.google.com
Gerrit-Attention: Ben Kao
ben.kao@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 17 Jun 2021 11:16:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Comment-In-Reply-To: Ben Kao
ben.kao@intel.com
Gerrit-MessageType: comment