Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70798 )
Change subject: cpu/x86/mtrr: rename local cpu_idx variable and make it const ......................................................................
cpu/x86/mtrr: rename local cpu_idx variable and make it const
After the previous patch this local variable is no longer the mpinit CPU index, but the LAPIC ID, so rename it. Since it will only be set once, it cal also be marked as const.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I4fad4e1095478213727bee8586852f9d5a7d18e9 --- M src/cpu/x86/mtrr/mtrr.c 1 file changed, 16 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/70798/1
diff --git a/src/cpu/x86/mtrr/mtrr.c b/src/cpu/x86/mtrr/mtrr.c index 744090a..d156d41 100644 --- a/src/cpu/x86/mtrr/mtrr.c +++ b/src/cpu/x86/mtrr/mtrr.c @@ -292,7 +292,7 @@ int j; int msr_num; int type_index; - unsigned int cpu_idx = lapicid(); + const unsigned int lapic_id = lapicid(); /* 8 ranges per msr. */ msr_t fixed_msrs[NUM_FIXED_MTRRS]; unsigned long msr_index[NUM_FIXED_MTRRS]; @@ -337,7 +337,7 @@
for (i = 0; i < ARRAY_SIZE(fixed_msrs); i++) printk(BIOS_DEBUG, "apic_id 0x%x: MTRR: Fixed MSR 0x%lx 0x%08x%08x\n", - cpu_idx, msr_index[i], fixed_msrs[i].hi, fixed_msrs[i].lo); + lapic_id, msr_index[i], fixed_msrs[i].hi, fixed_msrs[i].lo);
disable_cache(); for (i = 0; i < ARRAY_SIZE(fixed_msrs); i++)