Change in ...coreboot[master]: soc/intel/cannonlake: Add SOC_INTEL_WHISKEYLAKE kconfig

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31133 )

Change subject: soc/intel/cannonlake: Add SOC_INTEL_WHISKEYLAKE kconfig
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/31133/1/src/soc/intel/cannonlake/chip.h 
File src/soc/intel/cannonlake/chip.h:

https://review.coreboot.org/#/c/31133/1/src/soc/intel/cannonlake/chip.h@40 
PS1, Line 40: #define IS_CFL_OR_WHL(x, y) (IS_ENABLED(x) || IS_ENABLED(y))
IMHO, there's no need to pass parameters to this macro. It could be something like:

#define IS_CFL_OR_WHL (IS_ENABLED(CONFIG_SOC_INTEL_COFFEELAKE, CONFIG_SOC_INTEL_WHISKEYLAKE) || IS_ENABLED(y))