Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46485 )
Change subject: mb/intel/adlrvp: Add support for DDR5 memory
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46485/7/src/mainboard/intel/adlrvp/...
File src/mainboard/intel/adlrvp/variants/adlrvp_p/memory.c:
https://review.coreboot.org/c/coreboot/+/46485/7/src/mainboard/intel/adlrvp/...
PS7, Line 62: .rcomp_targets = {50, 30, 30, 30, 27},
It would be nice to provide const arrays for the recommended Rcomp target values in SoC code.
Sure Angel. Nice feedback. i believe you meant to make rcomp_resistor and rcomp_targets both const?
https://github.com/coreboot/coreboot/blob/master/src/soc/intel/alderlake/inc...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46485
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4711d66c7b4b7b09e15a4d06e28c876ec35bc192
Gerrit-Change-Number: 46485
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Balaji Manigandan
balaji.bmg@gmail.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subi.banik@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 04 Nov 2020 13:23:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment