build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55263 )
Change subject: ec: Add Star Labs ITE 5570E support ......................................................................
Patch Set 1:
(30 comments)
File src/ec/starlabs/it5570/acpi/ac.asl:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/ab9aacb0_6b06e0db PS1, Line 32: trailing whitespace
File src/ec/starlabs/it5570/acpi/battery.asl:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/0326eb1f_d9b364d0 PS1, Line 41: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/53ea74f2_4c7a4832 PS1, Line 50: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/e6bbc2e7_6d1b2573 PS1, Line 67: trailing whitespace
File src/ec/starlabs/it5570/acpi/cmos.asl:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/968850d4_ec2030a6 PS1, Line 6: NVRI, 8, trailing whitespace
File src/ec/starlabs/it5570/acpi/ec.asl:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/1944a95a_1b66f46b PS1, Line 21: // Our embedded controller device. trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/5c9213f8_1cac9299 PS1, Line 24: Name(_HID, EISAID("PNP0C09")) trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/424406c3_02b13416 PS1, Line 61: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/ed177ec4_1d04b861 PS1, Line 92: B1RP, 8, //0x93 Battery#1 Remaining percentage trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/40d52b1b_5d526708 PS1, Line 136: Local0 = Acquire(ECMT, 1000) // save Acquire result so we can check for Mutex acquired trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/19770a1b_5497022a PS1, Line 146: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/6446ba4e_f74d6b3f PS1, Line 154: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/7f4dfdd0_529b2e6b PS1, Line 159: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/a60805a4_f90bf8ec PS1, Line 162: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/aa79d77a_662515da PS1, Line 165: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/b7e98ba7_8eb794d3 PS1, Line 167: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/f392702f_35a24047 PS1, Line 177: trailing whitespace
File src/ec/starlabs/it5570/acpi/hid.asl:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/df93b12c_c7710830 PS1, Line 12: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/e1dc2f7f_0617a4c7 PS1, Line 21: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/2b4ddbf3_8e59dae3 PS1, Line 28: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/a40bca71_183933a5 PS1, Line 38: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/7a617fa3_272b3863 PS1, Line 48: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/6630fb55_a180569d PS1, Line 74: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/1558dc78_008ed2bb PS1, Line 98: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/b2b1401e_b07d3b97 PS1, Line 102: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/c72781f5_330e2e34 PS1, Line 106: trailing whitespace
File src/ec/starlabs/it5570/acpi/keyboard.asl:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/65a0fcac_9120cf0f PS1, Line 17: } trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/914a6956_61dd9e96 PS1, Line 22: _SB.HIDD.HPEM(8) trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/9a8b227e_ec11954b PS1, Line 29: } trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120926): https://review.coreboot.org/c/coreboot/+/55263/comment/53920db5_afb3ba10 PS1, Line 34: } trailing whitespace
-
build bot (Jenkins) (Code Review)