Change in ...coreboot[master]: [TEST]arch/x86/car.ld: Make the vboot tpm log symbols conditional
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32383
Change subject: [TEST]arch/x86/car.ld: Make the vboot tpm log symbols conditional ......................................................................
[TEST]arch/x86/car.ld: Make the vboot tpm log symbols conditional
Without vboot there is no need for these symbols.
Change-Id: I96391b7817c79f760713c67bc469164b5514879e Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/arch/x86/car.ld 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/32383/1
diff --git a/src/arch/x86/car.ld b/src/arch/x86/car.ld index 37fb087..93803a1 100644 --- a/src/arch/x86/car.ld +++ b/src/arch/x86/car.ld @@ -34,7 +34,9 @@ /* Vboot measured boot TCPA log measurements. * Needs to be transferred until CBMEM is available */ +#if CONFIG(VBOOT) VBOOT2_TPM_LOG(., 2K) +#endif /* Stack for CAR stages. Since it persists across all stages that * use CAR it can be reused. The chipset/SoC is expected to provide * the stack size. */
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32383 )
Change subject: [TEST]arch/x86/car.ld: Make the vboot tpm log symbols conditional ......................................................................
Patch Set 1:
Those vboot linker symbols conflicts with the ivybridge mrc.bin heap which is fixed at 0xff7e1000 with CONFIG_DCACHE_RAM_BASE at 0xff7e000. To properly fix that a separate car.ld or a lot of #if's are needed. Another option is to mess with the CAR setup which probably means using more MTRR's . If someone is capable of doing it a rebuild with the heap at a proper location would be nice.
Hello Kyösti Mälkki, Julius Werner, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32383
to look at the new patch set (#2).
Change subject: arch/x86/car.ld: Make the vboot tpm log symbols conditional ......................................................................
arch/x86/car.ld: Make the vboot tpm log symbols conditional
Without vboot there is no need for these symbols.
Change-Id: I96391b7817c79f760713c67bc469164b5514879e Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/arch/x86/car.ld 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/32383/2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32383 )
Change subject: arch/x86/car.ld: Make the vboot tpm log symbols conditional ......................................................................
Patch Set 3: Code-Review+1
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32383 )
Change subject: arch/x86/car.ld: Make the vboot tpm log symbols conditional ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32383/3/src/arch/x86/car.ld File src/arch/x86/car.ld:
https://review.coreboot.org/#/c/32383/3/src/arch/x86/car.ld@37 PS3, Line 37: #if CONFIG(VBOOT) VBOOT_MEASURED_BOOT I'd prefer to have it in src/include/memlayout.h as other platforms use VBOOT2_TPM_LOG, too.
Hello Kyösti Mälkki, Julius Werner, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32383
to look at the new patch set (#4).
Change subject: arch/x86/car.ld: Make the vboot tpm log symbols conditional ......................................................................
arch/x86/car.ld: Make the vboot tpm log symbols conditional
Without VBOOT_MEASURED_BOOT there is no need for these symbols.
Change-Id: I96391b7817c79f760713c67bc469164b5514879e Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/arch/x86/car.ld 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/32383/4
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32383 )
Change subject: arch/x86/car.ld: Make the vboot tpm log symbols conditional ......................................................................
Patch Set 4: Code-Review+1
is VBOOT_MEASURED_BOOT build tested by jenkins?
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32383 )
Change subject: arch/x86/car.ld: Make the vboot tpm log symbols conditional ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32383 )
Change subject: arch/x86/car.ld: Make the vboot tpm log symbols conditional ......................................................................
arch/x86/car.ld: Make the vboot tpm log symbols conditional
Without VBOOT_MEASURED_BOOT there is no need for these symbols.
Change-Id: I96391b7817c79f760713c67bc469164b5514879e Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/32383 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/arch/x86/car.ld 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Patrick Rudolph: Looks good to me, but someone else must approve
diff --git a/src/arch/x86/car.ld b/src/arch/x86/car.ld index d97df19..7b20a14 100644 --- a/src/arch/x86/car.ld +++ b/src/arch/x86/car.ld @@ -34,7 +34,9 @@ /* Vboot measured boot TCPA log measurements. * Needs to be transferred until CBMEM is available */ +#if CONFIG(VBOOT_MEASURED_BOOT) VBOOT2_TPM_LOG(., 2K) +#endif /* Stack for CAR stages. Since it persists across all stages that * use CAR it can be reused. The chipset/SoC is expected to provide * the stack size. */
-
Arthur Heymans (Code Review) -
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)