Attention is currently required from: Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70230 )
Change subject: mb/google/herobrine: NVMe id determined by logical (not physical) bit
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/70230/comment/fd210ad9_208738fd
PS2, Line 100: & sku_bits_mask
Remove this. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70230
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa75d2418d6a2351d874842e8678bd6ad3c92526
Gerrit-Change-Number: 70230
Gerrit-PatchSet: 3
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Douglas Anderson
dianders@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Sat, 03 Dec 2022 01:04:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Douglas Anderson
dianders@chromium.org
Gerrit-MessageType: comment