HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32783
Change subject: src/mainboard: Remove unneeded include <arch/io.h> ......................................................................
src/mainboard: Remove unneeded include <arch/io.h>
Change-Id: I73c557d6ef009fb2cac35fdea500dee76f525330 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/apple/macbook21/romstage.c M src/mainboard/asus/p5gc-mx/romstage.c M src/mainboard/asus/p5qpl-am/romstage.c M src/mainboard/ibase/mb899/romstage.c M src/mainboard/intel/baskingridge/chromeos.c M src/mainboard/intel/dcp847ske/early_southbridge.c M src/mainboard/intel/emeraldlake2/chromeos.c M src/mainboard/kontron/986lcd-m/romstage.c M src/mainboard/lenovo/x60/romstage.c M src/mainboard/lenovo/z61t/romstage.c 10 files changed, 0 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/32783/1
diff --git a/src/mainboard/apple/macbook21/romstage.c b/src/mainboard/apple/macbook21/romstage.c index 468cffb..1c84c84 100644 --- a/src/mainboard/apple/macbook21/romstage.c +++ b/src/mainboard/apple/macbook21/romstage.c @@ -18,7 +18,6 @@ /* __PRE_RAM__ means: use "unsigned" for device, not a struct. */
#include <stdint.h> -#include <arch/io.h> #include <cf9_reset.h> #include <device/pci_ops.h> #include <device/pci_def.h> diff --git a/src/mainboard/asus/p5gc-mx/romstage.c b/src/mainboard/asus/p5gc-mx/romstage.c index 08379f7..b076b9d 100644 --- a/src/mainboard/asus/p5gc-mx/romstage.c +++ b/src/mainboard/asus/p5gc-mx/romstage.c @@ -18,7 +18,6 @@ // __PRE_RAM__ means: use "unsigned" for device, not a struct.
#include <stdint.h> -#include <arch/io.h> #include <cf9_reset.h> #include <device/pnp_ops.h> #include <device/pci_ops.h> diff --git a/src/mainboard/asus/p5qpl-am/romstage.c b/src/mainboard/asus/p5qpl-am/romstage.c index bd6bfc6..7d02843 100644 --- a/src/mainboard/asus/p5qpl-am/romstage.c +++ b/src/mainboard/asus/p5qpl-am/romstage.c @@ -15,7 +15,6 @@ * GNU General Public License for more details. */
-#include <arch/io.h> #include <cf9_reset.h> #include <device/pnp_ops.h> #include <device/pci_ops.h> diff --git a/src/mainboard/ibase/mb899/romstage.c b/src/mainboard/ibase/mb899/romstage.c index 9cb1144..c98556c 100644 --- a/src/mainboard/ibase/mb899/romstage.c +++ b/src/mainboard/ibase/mb899/romstage.c @@ -16,7 +16,6 @@ // __PRE_RAM__ means: use "unsigned" for device, not a struct.
#include <stdint.h> -#include <arch/io.h> #include <cf9_reset.h> #include <device/pnp_ops.h> #include <device/pci_ops.h> diff --git a/src/mainboard/intel/baskingridge/chromeos.c b/src/mainboard/intel/baskingridge/chromeos.c index 1673622..6561927 100644 --- a/src/mainboard/intel/baskingridge/chromeos.c +++ b/src/mainboard/intel/baskingridge/chromeos.c @@ -15,7 +15,6 @@
#include <string.h> #include <bootmode.h> -#include <arch/io.h> #include <device/pci_ops.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/mainboard/intel/dcp847ske/early_southbridge.c b/src/mainboard/intel/dcp847ske/early_southbridge.c index 778525f..705ace9 100644 --- a/src/mainboard/intel/dcp847ske/early_southbridge.c +++ b/src/mainboard/intel/dcp847ske/early_southbridge.c @@ -17,7 +17,6 @@ */
#include <stdint.h> -#include <arch/io.h> #include <cf9_reset.h> #include <device/pci_ops.h> #include <device/pci_def.h> diff --git a/src/mainboard/intel/emeraldlake2/chromeos.c b/src/mainboard/intel/emeraldlake2/chromeos.c index 219eefb..699141f 100644 --- a/src/mainboard/intel/emeraldlake2/chromeos.c +++ b/src/mainboard/intel/emeraldlake2/chromeos.c @@ -15,7 +15,6 @@
#include <string.h> #include <bootmode.h> -#include <arch/io.h> #include <device/pci_ops.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/mainboard/kontron/986lcd-m/romstage.c b/src/mainboard/kontron/986lcd-m/romstage.c index b85bd68..85a82c5 100644 --- a/src/mainboard/kontron/986lcd-m/romstage.c +++ b/src/mainboard/kontron/986lcd-m/romstage.c @@ -16,7 +16,6 @@ /* __PRE_RAM__ means: use "unsigned" for device, not a struct. */
#include <stdint.h> -#include <arch/io.h> #include <cf9_reset.h> #include <console/console.h> #include <cpu/intel/romstage.h> diff --git a/src/mainboard/lenovo/x60/romstage.c b/src/mainboard/lenovo/x60/romstage.c index ea93707..b66ef66 100644 --- a/src/mainboard/lenovo/x60/romstage.c +++ b/src/mainboard/lenovo/x60/romstage.c @@ -18,7 +18,6 @@ // __PRE_RAM__ means: use "unsigned" for device, not a struct.
#include <stdint.h> -#include <arch/io.h> #include <cf9_reset.h> #include <device/pnp_ops.h> #include <device/pci_ops.h> diff --git a/src/mainboard/lenovo/z61t/romstage.c b/src/mainboard/lenovo/z61t/romstage.c index 47a52db..502eac3 100644 --- a/src/mainboard/lenovo/z61t/romstage.c +++ b/src/mainboard/lenovo/z61t/romstage.c @@ -18,7 +18,6 @@ // __PRE_RAM__ means: use "unsigned" for device, not a struct.
#include <stdint.h> -#include <arch/io.h> #include <cf9_reset.h> #include <device/pnp_ops.h> #include <device/pci_ops.h>
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32783 )
Change subject: src/mainboard: Remove unneeded include <arch/io.h> ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32783 )
Change subject: src/mainboard: Remove unneeded include <arch/io.h> ......................................................................
src/mainboard: Remove unneeded include <arch/io.h>
Change-Id: I73c557d6ef009fb2cac35fdea500dee76f525330 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32783 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/apple/macbook21/romstage.c M src/mainboard/asus/p5gc-mx/romstage.c M src/mainboard/asus/p5qpl-am/romstage.c M src/mainboard/ibase/mb899/romstage.c M src/mainboard/intel/baskingridge/chromeos.c M src/mainboard/intel/dcp847ske/early_southbridge.c M src/mainboard/intel/emeraldlake2/chromeos.c M src/mainboard/kontron/986lcd-m/romstage.c M src/mainboard/lenovo/x60/romstage.c M src/mainboard/lenovo/z61t/romstage.c 10 files changed, 0 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/mainboard/apple/macbook21/romstage.c b/src/mainboard/apple/macbook21/romstage.c index 468cffb..1c84c84 100644 --- a/src/mainboard/apple/macbook21/romstage.c +++ b/src/mainboard/apple/macbook21/romstage.c @@ -18,7 +18,6 @@ /* __PRE_RAM__ means: use "unsigned" for device, not a struct. */
#include <stdint.h> -#include <arch/io.h> #include <cf9_reset.h> #include <device/pci_ops.h> #include <device/pci_def.h> diff --git a/src/mainboard/asus/p5gc-mx/romstage.c b/src/mainboard/asus/p5gc-mx/romstage.c index 08379f7..b076b9d 100644 --- a/src/mainboard/asus/p5gc-mx/romstage.c +++ b/src/mainboard/asus/p5gc-mx/romstage.c @@ -18,7 +18,6 @@ // __PRE_RAM__ means: use "unsigned" for device, not a struct.
#include <stdint.h> -#include <arch/io.h> #include <cf9_reset.h> #include <device/pnp_ops.h> #include <device/pci_ops.h> diff --git a/src/mainboard/asus/p5qpl-am/romstage.c b/src/mainboard/asus/p5qpl-am/romstage.c index bd6bfc6..7d02843 100644 --- a/src/mainboard/asus/p5qpl-am/romstage.c +++ b/src/mainboard/asus/p5qpl-am/romstage.c @@ -15,7 +15,6 @@ * GNU General Public License for more details. */
-#include <arch/io.h> #include <cf9_reset.h> #include <device/pnp_ops.h> #include <device/pci_ops.h> diff --git a/src/mainboard/ibase/mb899/romstage.c b/src/mainboard/ibase/mb899/romstage.c index 9cb1144..c98556c 100644 --- a/src/mainboard/ibase/mb899/romstage.c +++ b/src/mainboard/ibase/mb899/romstage.c @@ -16,7 +16,6 @@ // __PRE_RAM__ means: use "unsigned" for device, not a struct.
#include <stdint.h> -#include <arch/io.h> #include <cf9_reset.h> #include <device/pnp_ops.h> #include <device/pci_ops.h> diff --git a/src/mainboard/intel/baskingridge/chromeos.c b/src/mainboard/intel/baskingridge/chromeos.c index 1673622..6561927 100644 --- a/src/mainboard/intel/baskingridge/chromeos.c +++ b/src/mainboard/intel/baskingridge/chromeos.c @@ -15,7 +15,6 @@
#include <string.h> #include <bootmode.h> -#include <arch/io.h> #include <device/pci_ops.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/mainboard/intel/dcp847ske/early_southbridge.c b/src/mainboard/intel/dcp847ske/early_southbridge.c index 778525f..705ace9 100644 --- a/src/mainboard/intel/dcp847ske/early_southbridge.c +++ b/src/mainboard/intel/dcp847ske/early_southbridge.c @@ -17,7 +17,6 @@ */
#include <stdint.h> -#include <arch/io.h> #include <cf9_reset.h> #include <device/pci_ops.h> #include <device/pci_def.h> diff --git a/src/mainboard/intel/emeraldlake2/chromeos.c b/src/mainboard/intel/emeraldlake2/chromeos.c index 219eefb..699141f 100644 --- a/src/mainboard/intel/emeraldlake2/chromeos.c +++ b/src/mainboard/intel/emeraldlake2/chromeos.c @@ -15,7 +15,6 @@
#include <string.h> #include <bootmode.h> -#include <arch/io.h> #include <device/pci_ops.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/mainboard/kontron/986lcd-m/romstage.c b/src/mainboard/kontron/986lcd-m/romstage.c index b85bd68..85a82c5 100644 --- a/src/mainboard/kontron/986lcd-m/romstage.c +++ b/src/mainboard/kontron/986lcd-m/romstage.c @@ -16,7 +16,6 @@ /* __PRE_RAM__ means: use "unsigned" for device, not a struct. */
#include <stdint.h> -#include <arch/io.h> #include <cf9_reset.h> #include <console/console.h> #include <cpu/intel/romstage.h> diff --git a/src/mainboard/lenovo/x60/romstage.c b/src/mainboard/lenovo/x60/romstage.c index ea93707..b66ef66 100644 --- a/src/mainboard/lenovo/x60/romstage.c +++ b/src/mainboard/lenovo/x60/romstage.c @@ -18,7 +18,6 @@ // __PRE_RAM__ means: use "unsigned" for device, not a struct.
#include <stdint.h> -#include <arch/io.h> #include <cf9_reset.h> #include <device/pnp_ops.h> #include <device/pci_ops.h> diff --git a/src/mainboard/lenovo/z61t/romstage.c b/src/mainboard/lenovo/z61t/romstage.c index 47a52db..502eac3 100644 --- a/src/mainboard/lenovo/z61t/romstage.c +++ b/src/mainboard/lenovo/z61t/romstage.c @@ -18,7 +18,6 @@ // __PRE_RAM__ means: use "unsigned" for device, not a struct.
#include <stdint.h> -#include <arch/io.h> #include <cf9_reset.h> #include <device/pnp_ops.h> #include <device/pci_ops.h>
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)