Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40386 )
Change subject: soc/intel/xeon_sp/cpx: Finalize PCU configuration
......................................................................
Patch Set 27:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40386/27/src/soc/intel/xeon_sp/cpx/...
File src/soc/intel/xeon_sp/cpx/soc_util.c:
https://review.coreboot.org/c/coreboot/+/40386/27/src/soc/intel/xeon_sp/cpx/...
PS27, Line 304: uint32_t sbsp_socket_id = 0;
Yes, it may not be socket 0. I will add a comment about it. […]
I would add a FIXME comment:
/* FIXME: This may need to be changed for multi-socket platforms */
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40386
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f5b18d66b351acecdc7b3f515a552c36f08eb61
Gerrit-Change-Number: 40386
Gerrit-PatchSet: 27
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 17 Jun 2020 18:44:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment