Attention is currently required from: Boris Mittelberg, Caveh Jalali, Elyes Haouas.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76838?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: ec/google/chromeec/ec_commands.h: Use C99 flexible arrays
......................................................................
Patch Set 1:
(1 comment)
File src/ec/google/chromeec/ec_commands.h:
PS1:
This file is a copy of [ChromeEC ec_commands.h](https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/main/i...). I do not think it should be altered this way as any update to source file will lead to more differences than anticipated. I think it would be better to fix this issue in the source repository first (if feasible).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76838?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa8ec6638d1141251ecaae6668ca07efa9d14006
Gerrit-Change-Number: 76838
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Tue, 01 Aug 2023 12:48:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment