Attention is currently required from: Julius Werner, Tim Wawrzynczak, Felix Held. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62600 )
Change subject: commonlib/bsd: Remove cb_err_t ......................................................................
Patch Set 1:
(6 comments)
File payloads/libpayload/libc/fmap.c:
https://review.coreboot.org/c/coreboot/+/62600/comment/edd2aaf6_f0e8aa00 PS1, Line 42: size_t *size) Indentation.
File payloads/libpayload/tests/libcbfs/cbfs-lookup-test.c:
https://review.coreboot.org/c/coreboot/+/62600/comment/d47b2e61_2bb28f3e PS1, Line 60: union cbfs_mdata *mdata_out, size_t *data_offset_out) Indentation.
https://review.coreboot.org/c/coreboot/+/62600/comment/1e74d435_88e093d6 PS1, Line 91: size_t *data_offset_out, struct vb2_hash *metadata_hash) Indentation.
File payloads/libpayload/tests/libcbfs/cbfs-verification-test.c:
https://review.coreboot.org/c/coreboot/+/62600/comment/83f72fb7_ef35a92f PS1, Line 57: union cbfs_mdata *mdata_out, size_t *data_offset_out) Indentation.
File src/drivers/parade/ps8640/ps8640.c:
https://review.coreboot.org/c/coreboot/+/62600/comment/da2fc209_215610e9 PS1, Line 84: static enum cb_err ps8640_bridge_aux_request(uint8_t bus, : uint8_t chip, : unsigned int target_reg, : unsigned int total_size, : enum aux_request request, : uint8_t *data) nit: Can it be changed to occupy less lines?
File src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c:
https://review.coreboot.org/c/coreboot/+/62600/comment/abe7b3d6_37d83623 PS1, Line 158: static enum cb_err sn65dsi86_bridge_aux_request(uint8_t bus, : uint8_t chip, : unsigned int target_reg, : unsigned int total_size, : enum aux_request request, : uint8_t *data) nit: Can it be changed to occupy less lines?
-
Jakub Czapiga (Code Review)