Change in coreboot[master]: mb/google/hatch/Kconfig: Disable VBOOT_EARLY_EC_SYNC on Puff
Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39461 )
Change subject: mb/google/hatch/Kconfig: Disable VBOOT_EARLY_EC_SYNC on Puff ......................................................................
mb/google/hatch/Kconfig: Disable VBOOT_EARLY_EC_SYNC on Puff
Early ec sync needs to be disabled for EFS2 to function.
BUG=b:151115320 BRANCH=none TEST=none
Change-Id: I384d072d9614a5cd30837f7cdfb777ad5e4f6b19 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/39461/1
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 92d94db..6ae79b9 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -128,7 +128,8 @@ config VBOOT select HAS_RECOVERY_MRC_CACHE select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN - select VBOOT_EARLY_EC_SYNC + # FIXME: allow kconfig to select on a subset of boards only + select VBOOT_EARLY_EC_SYNC if !BOARD_GOOGLE_PUFF select VBOOT_LID_SWITCH
endif # BOARD_GOOGLE_BASEBOARD_HATCH
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39461 )
Change subject: mb/google/hatch/Kconfig: Disable VBOOT_EARLY_EC_SYNC on Puff ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/39461/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39461/1//COMMIT_MSG@9 PS1, Line 9: Early ec sync needs to be disabled for EFS2 to function. Just curious, why is that?
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39461 )
Change subject: mb/google/hatch/Kconfig: Disable VBOOT_EARLY_EC_SYNC on Puff ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39461/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39461/1//COMMIT_MSG@9 PS1, Line 9: Early ec sync needs to be disabled for EFS2 to function.
Just curious, why is that?
It is simply just a matter that it isn't supported as part of EFS2 enablement. More about EFSv2 can be found here: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_referen...
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39461 )
Change subject: mb/google/hatch/Kconfig: Disable VBOOT_EARLY_EC_SYNC on Puff ......................................................................
mb/google/hatch/Kconfig: Disable VBOOT_EARLY_EC_SYNC on Puff
Early ec sync needs to be disabled for EFS2 to function.
BUG=b:151115320 BRANCH=none TEST=none
Change-Id: I384d072d9614a5cd30837f7cdfb777ad5e4f6b19 Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39461 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index b0d2e75..512d310 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -130,7 +130,8 @@ config VBOOT select HAS_RECOVERY_MRC_CACHE select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN - select VBOOT_EARLY_EC_SYNC + # FIXME: allow kconfig to select on a subset of boards only + select VBOOT_EARLY_EC_SYNC if !BOARD_GOOGLE_PUFF select VBOOT_LID_SWITCH
endif # BOARD_GOOGLE_BASEBOARD_HATCH
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39461 )
Change subject: mb/google/hatch/Kconfig: Disable VBOOT_EARLY_EC_SYNC on Puff ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1331 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1330 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1329
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Edward O'Callaghan (Code Review)
-
Tim Wawrzynczak (Code Review)