Change in coreboot[master]: src/mainboard/intel/cannonlake: Add gpio support for cannonlake
John Zhao has posted comments on this change. ( https://review.coreboot.org/21139 )
Change subject: src/mainboard/intel/cannonlake: Add gpio support for cannonlake ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/21139/1/src/mainboard/intel/cannonlake_rvp/v... File src/mainboard/intel/cannonlake_rvp/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/21139/1/src/mainboard/intel/cannonlake_rvp/v... PS1, Line 30: /* A7 : PRIQAB_GSP10_CS1B */ : PAD_CFG_GPI_ACPI_SCI(GPP_A7, 20K_PU, PLTRST, NONE),
i think you should put the comment after macro for the same pin.
The gpio pins configuration and comments format is consistent with other platforms like poppy.
-
John Zhao (Code Review)