Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40308 )
Change subject: mb/ocp/tiogapass: Override SMBIOS data
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40308/6/src/mainboard/ocp/tiogapass...
File src/mainboard/ocp/tiogapass/ramstage.c:
https://review.coreboot.org/c/coreboot/+/40308/6/src/mainboard/ocp/tiogapass...
PS6, Line 51: return CONFIG_MAINBOARD_SERIAL_NUMBER;
Is it CONFIG_MAINBOARD_SERIAL_NUMBER? I can't find the typo.
Perhaps you need to add a new config - CONFIG_MAINBOARD_SYSTEM_VERSION?
To avoid confusion
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40308
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08c958dfad83216cd12545760a19d205efc2515b
Gerrit-Change-Number: 40308
Gerrit-PatchSet: 9
Gerrit-Owner: Johnny Lin
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Tue, 14 Apr 2020 14:41:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Johnny Lin
Gerrit-MessageType: comment