Change in coreboot[master]: soc/amd/common/psp: move v1-only mailbox commands to separate section
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47180 )
Change subject: soc/amd/common/psp: move v1-only mailbox commands to separate section ......................................................................
soc/amd/common/psp: move v1-only mailbox commands to separate section
Two of the PSP mailbox commands are only applicable to the first generation of PSP mailbox interface.
Change-Id: Ice940ee780c3d96ae1d9ec7ba49ea4add00e8723 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/common/block/psp/psp_def.h 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/47180/1
diff --git a/src/soc/amd/common/block/psp/psp_def.h b/src/soc/amd/common/block/psp/psp_def.h index 47741fa..38d6206 100644 --- a/src/soc/amd/common/block/psp/psp_def.h +++ b/src/soc/amd/common/block/psp/psp_def.h @@ -18,9 +18,10 @@ #define MBOX_BIOS_CMD_CLEAR_S3_STS 0x07 #define MBOX_BIOS_CMD_S3_DATA_INFO 0x08 #define MBOX_BIOS_CMD_NOP 0x09 +#define MBOX_BIOS_CMD_ABORT 0xfe +/* x86 to PSP commands, v1 */ #define MBOX_BIOS_CMD_SMU_FW 0x19 #define MBOX_BIOS_CMD_SMU_FW2 0x1a -#define MBOX_BIOS_CMD_ABORT 0xfe
/* generic PSP interface status, v1 */ #define PSPV1_STATUS_INITIALIZED BIT(0)
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47180 )
Change subject: soc/amd/common/psp: move v1-only mailbox commands to separate section ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47180 )
Change subject: soc/amd/common/psp: move v1-only mailbox commands to separate section ......................................................................
soc/amd/common/psp: move v1-only mailbox commands to separate section
Two of the PSP mailbox commands are only applicable to the first generation of PSP mailbox interface.
Change-Id: Ice940ee780c3d96ae1d9ec7ba49ea4add00e8723 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/47180 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/common/block/psp/psp_def.h 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/common/block/psp/psp_def.h b/src/soc/amd/common/block/psp/psp_def.h index 47741fa..38d6206 100644 --- a/src/soc/amd/common/block/psp/psp_def.h +++ b/src/soc/amd/common/block/psp/psp_def.h @@ -18,9 +18,10 @@ #define MBOX_BIOS_CMD_CLEAR_S3_STS 0x07 #define MBOX_BIOS_CMD_S3_DATA_INFO 0x08 #define MBOX_BIOS_CMD_NOP 0x09 +#define MBOX_BIOS_CMD_ABORT 0xfe +/* x86 to PSP commands, v1 */ #define MBOX_BIOS_CMD_SMU_FW 0x19 #define MBOX_BIOS_CMD_SMU_FW2 0x1a -#define MBOX_BIOS_CMD_ABORT 0xfe
/* generic PSP interface status, v1 */ #define PSPV1_STATUS_INITIALIZED BIT(0)
-
Felix Held (Code Review) -
Marshall Dawson (Code Review)