Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Andrey Petrov, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60638 )
Change subject: drivers/intel/fsp2_0/notify.c: Clean up some cosmetics
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/intel/fsp2_0/notify.c:
https://review.coreboot.org/c/coreboot/+/60638/comment/fe5f8a15_df901a6b
PS1, Line 76: {
: }
nit: I would move these into the line before.
I don't see anything in our coding style about this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60638
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2dafd677abbdd892745fea1bf4414f6e0d5549bb
Gerrit-Change-Number: 60638
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 01 Jan 2022 16:53:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment