build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37426 )
Change subject: soc/intel/tigerlake: Fix build issues ......................................................................
Patch Set 3:
(152 comments)
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 210: ProbeTypeDciOob = 0x02, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 215: ProbeTypeManual = 0x07, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 217: } DebugConsent; trailing whitespace
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 262: trailing whitespace
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.c:
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 38: switch (dev->path.usb.port_type) { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 38: switch (dev->path.usb.port_type) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 39: case 0: code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 39: case 0: please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 40: /* Root Hub */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 41: return "RHUB"; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 41: return "RHUB"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 42: case 2: code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 42: case 2: please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 43: /* USB2 ports */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 44: switch (dev->path.usb.port_id) { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 44: switch (dev->path.usb.port_id) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 45: case 0: return "HS01"; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 45: case 0: return "HS01"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 46: case 1: return "HS02"; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 46: case 1: return "HS02"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 47: case 2: return "HS03"; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 47: case 2: return "HS03"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 48: case 3: return "HS04"; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 48: case 3: return "HS04"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 49: case 4: return "HS05"; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 49: case 4: return "HS05"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 50: case 5: return "HS06"; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 50: case 5: return "HS06"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 51: case 6: return "HS07"; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 51: case 6: return "HS07"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 52: case 7: return "HS08"; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 52: case 7: return "HS08"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 53: case 8: return "HS09"; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 53: case 8: return "HS09"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 54: case 9: return "HS10"; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 54: case 9: return "HS10"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 55: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 55: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 56: break; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 56: break; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 57: case 3: code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 57: case 3: please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 58: /* USB3 ports */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 59: switch (dev->path.usb.port_id) { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 59: switch (dev->path.usb.port_id) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 60: case 0: return "SS01"; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 60: case 0: return "SS01"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 61: case 1: return "SS02"; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 61: case 1: return "SS02"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 62: case 2: return "SS03"; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 62: case 2: return "SS03"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 63: case 3: return "SS04"; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 63: case 3: return "SS04"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 64: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 64: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 65: break; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 65: break; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 66: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 66: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 67: return NULL; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 67: return NULL; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 68: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 68: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 92: #endif adding a line without newline at end of file
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/irq.h:
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 20: #define GPIO_IRQ15 15 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 22: #define PCH_IRQ10 10 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 23: #define PCH_IRQ11 11 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 25: #define SCI_IRQ9 9 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 26: #define SCI_IRQ10 10 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 27: #define SCI_IRQ11 11 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 28: #define SCI_IRQ20 20 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 29: #define SCI_IRQ21 21 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 30: #define SCI_IRQ22 22 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 31: #define SCI_IRQ23 23 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 33: #define TCO_IRQ9 9 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 34: #define TCO_IRQ10 10 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 35: #define TCO_IRQ11 11 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 36: #define TCO_IRQ20 20 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 37: #define TCO_IRQ21 21 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 38: #define TCO_IRQ22 22 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 41: #define LPSS_I2C0_IRQ 27 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 42: #define LPSS_I2C1_IRQ 28 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 43: #define LPSS_I2C2_IRQ 29 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 44: #define LPSS_I2C3_IRQ 30 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 45: #define LPSS_I2C4_IRQ 31 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 46: #define LPSS_I2C5_IRQ 32 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 47: #define LPSS_I2C6_IRQ 16 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 48: #define LPSS_I2C7_IRQ 17 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 49: #define LPSS_SPI0_IRQ 36 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 50: #define LPSS_SPI1_IRQ 37 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 51: #define LPSS_SPI2_IRQ 24 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 52: #define LPSS_SPI3_IRQ 23 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 53: #define LPSS_SPI4_IRQ 24 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 54: #define LPSS_SPI5_IRQ 25 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 55: #define LPSS_SPI6_IRQ 38 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 56: #define LPSS_UART0_IRQ 34 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 57: #define LPSS_UART1_IRQ 35 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 58: #define LPSS_UART2_IRQ 33 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 59: #define LPSS_UART3_IRQ 19 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 60: #define LPSS_UART4_IRQ 20 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 61: #define LPSS_UART5_IRQ 21 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 62: #define LPSS_UART6_IRQ 22 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 64: #define SDIO_IRQ 22 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 66: #define eSPI_IRQ 16 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 67: #define P2SB_IRQ 17 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 68: #define PMC_IRQ 18 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 69: #define HDA_IRQ 19 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 71: #define eMMC_IRQ 16 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 72: #define SD_IRQ 19 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 74: #define PCIE_1_IRQ 16 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 75: #define PCIE_2_IRQ 17 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 76: #define PCIE_3_IRQ 18 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 77: #define PCIE_4_IRQ 19 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 78: #define PCIE_5_IRQ 16 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 79: #define PCIE_6_IRQ 17 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 80: #define PCIE_7_IRQ 18 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 81: #define PCIE_8_IRQ 19 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 82: #define PCIE_9_IRQ 16 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 83: #define PCIE_10_IRQ 17 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 84: #define PCIE_11_IRQ 18 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 85: #define PCIE_12_IRQ 19 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 87: #define SATA_IRQ 16 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 89: #define HECI_1_IRQ 16 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 90: #define HECI_2_IRQ 17 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 91: #define IDER_IRQ 18 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 92: #define KT_IRQ 19 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 93: #define HECI_3_IRQ 16 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 95: #define xHCI_IRQ 16 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 96: #define xDCI_IRQ 17 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 97: #define USB2_xHCI_IRQ 16 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 98: #define USB2_xDCI_IRQ 17 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 99: #define PMC_SRAM_IRQ 18 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 100: #define THERMAL_IRQ 16 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 101: #define CNViBT_IRQ 18 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 102: #define CNViWIFI_IRQ 19 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 103: #define UFS_IRQ 16 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 104: #define CIO_INTA_IRQ 16 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 105: #define CIO_INTD_IRQ 19 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 106: #define ISH_IRQ 16 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 118: #define IGFX_IRQ 16 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 119: #define SA_THERMAL_IRQ 16 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 120: #define IPU_IRQ 16 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 121: #define GNA_IRQ 16 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/romstage.h:
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 21: void mainboard_fspm_params(FSPM_UPD *mupd); need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 27: BOARD_TYPE_MOBILE = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 27: BOARD_TYPE_MOBILE = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 28: BOARD_TYPE_DESKTOP = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 28: BOARD_TYPE_DESKTOP = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 29: BOARD_TYPE_ULT_ULX = 5, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 29: BOARD_TYPE_ULT_ULX = 5, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 30: BOARD_TYPE_SERVER = 7 code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 30: BOARD_TYPE_SERVER = 7 please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)