Attention is currently required from: Jakub Czapiga, Julius Werner, Jan Dabros. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52937 )
Change subject: tests: Enable config override for tests ......................................................................
Patch Set 2: Code-Review+2
(3 comments)
Patchset:
PS2: Just some minor things, looking good otherwise.
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/52937/comment/f572b572_3bf1aa23 PS2, Line 89: $(TEST_KCONFIG_AUTOHEADER) The rule doesn't seem to have any inputs except the variables, so I don't think that dependency is necessary
https://review.coreboot.org/c/coreboot/+/52937/comment/30e56883_1ec24860 PS2, Line 92: config.src.h should we generate this programmatically: $(notdir $(TEST_KCONFIG_AUTOHEADER))?
-
Patrick Georgi (Code Review)