Attention is currently required from: Akshu Agrawal, Matt Papageorge, Karthik Ramasubramanian, Felix Held.
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52035 )
Change subject: soc/amd/cezanne: Update FADT to support S0i3
......................................................................
Patch Set 4:
(1 comment)
This change is ready for review.
File src/soc/amd/cezanne/acpi.c:
https://review.coreboot.org/c/coreboot/+/52035/comment/24d51b53_d68fbe41
PS1, Line 88: ACPI_FADT_LOW_PWR_IDLE_S0
this should probably depend on the kconfig option introduced later in the patch train. […]
That's correct. I reordered and used the kconfig to decide.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52035
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59ef762a18903135f9daa902ba8d1e40c451e96c
Gerrit-Change-Number: 52035
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Akshu Agrawal
akshu.agrawal@amd.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Akshu Agrawal
akshu.agrawal@amd.com
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 09 Apr 2021 14:02:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment