Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41853 )
Change subject: mb/google/dedede: config spk_en gpio to low by default ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/41853/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41853/2//COMMIT_MSG@9 PS2, Line 9: gpio
speaker enable gpio
Done
https://review.coreboot.org/c/coreboot/+/41853/2//COMMIT_MSG@10 PS2, Line 10: so defaults it to 0
configure it low?
Done
https://review.coreboot.org/c/coreboot/+/41853/2//COMMIT_MSG@12 PS2, Line 12: BRANCH=None
not needed
Done
https://review.coreboot.org/c/coreboot/+/41853/2//COMMIT_MSG@14 PS2, Line 14: tested
tested speaker playback works fine?
Yes, speaker playback works. Updated the same.
https://review.coreboot.org/c/coreboot/+/41853/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/41853/2/src/mainboard/google/dedede... PS2, Line 178: GPP_D17
This is exposed in ACPI tables only for waddledoo. […]
Hi Furquan, for waddledee audio support is not enabled yet. Also since the Audio pin for waddledee is same as waddledoo (GPP_D17) it would be taken care.
-
Usha P (Code Review)