Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41791 )
Change subject: acpi: Add definitions for device sleep states ......................................................................
acpi: Add definitions for device sleep states
The ACPI device sleep states are different from system sleep states and many places hardcode to specific values that are difficult to decode without referring to the spec.
Change-Id: If5e732725b775742fd2a9fd0df697e312aa7bf20 Signed-off-by: Duncan Laurie dlaurie@google.com --- M src/include/acpi/acpi.h 1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/41791/1
diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index ea80e3b..34cb6ea 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -31,6 +31,14 @@ #define SLP_TYP_S5 5 #endif
+/* ACPI Device Sleep States */ +#define ACPI_DEVICE_SLEEP_D0 0 +#define ACPI_DEVICE_SLEEP_D1 1 +#define ACPI_DEVICE_SLEEP_D2 2 +#define ACPI_DEVICE_SLEEP_D3 3 +#define ACPI_DEVICE_SLEEP_D3_HOT ACPI_DEVICE_SLEEP_D3 +#define ACPI_DEVICE_SLEEP_D3_COLD 4 + #define ACPI_TABLE_CREATOR "COREBOOT" /* Must be exactly 8 bytes long! */ #define OEM_ID "COREv4" /* Must be exactly 6 bytes long! */
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41791 )
Change subject: acpi: Add definitions for device sleep states ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41791 )
Change subject: acpi: Add definitions for device sleep states ......................................................................
Patch Set 1: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41791 )
Change subject: acpi: Add definitions for device sleep states ......................................................................
acpi: Add definitions for device sleep states
The ACPI device sleep states are different from system sleep states and many places hardcode to specific values that are difficult to decode without referring to the spec.
Change-Id: If5e732725b775742fd2a9fd0df697e312aa7bf20 Signed-off-by: Duncan Laurie dlaurie@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41791 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/acpi/acpi.h 1 file changed, 8 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Furquan Shaikh: Looks good to me, approved
diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index ea80e3b..34cb6ea 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -31,6 +31,14 @@ #define SLP_TYP_S5 5 #endif
+/* ACPI Device Sleep States */ +#define ACPI_DEVICE_SLEEP_D0 0 +#define ACPI_DEVICE_SLEEP_D1 1 +#define ACPI_DEVICE_SLEEP_D2 2 +#define ACPI_DEVICE_SLEEP_D3 3 +#define ACPI_DEVICE_SLEEP_D3_HOT ACPI_DEVICE_SLEEP_D3 +#define ACPI_DEVICE_SLEEP_D3_COLD 4 + #define ACPI_TABLE_CREATOR "COREBOOT" /* Must be exactly 8 bytes long! */ #define OEM_ID "COREv4" /* Must be exactly 6 bytes long! */
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41791 )
Change subject: acpi: Add definitions for device sleep states ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4516 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4515 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4514 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4513
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Duncan Laurie (Code Review)
-
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)