Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29667 )
Change subject: mb/emulation/qemu-q35,qemu-i440fx: Add x86_64 support
......................................................................
Patch Set 32:
(1 comment)
https://review.coreboot.org/c/coreboot/+/29667/32/src/arch/x86/Kconfig
File src/arch/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/29667/32/src/arch/x86/Kconfig@55
PS32, Line 55: PAGING_IN_CACHE_AS_RAM
This symbol is used to set up linker symbols to set up PD in car. […]
That's some leftover of the earliest patches. It's not required any more and I'll remove it. Storing page tables in cbmem is possible, but not implemented for this PoC as coreboot doesn't benefit from accessing > 4G memory (on x86) yet.
2) seems a good idea.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29667
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2f02a95b2f91ab51043d4e81054354f4a6eb5d5
Gerrit-Change-Number: 29667
Gerrit-PatchSet: 32
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 18 Oct 2019 18:12:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment