Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, John Zhao.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56024 )
Change subject: drivers/usb/acpi: Create function to get PLD information
......................................................................
Patch Set 6:
(1 comment)
File src/drivers/usb/acpi/usb_acpi.c:
https://review.coreboot.org/c/coreboot/+/56024/comment/c4c8cc1f_6e70d967
PS4, Line 129: static struct acpi_pld pld;
True Furquan... […]
We can't just remove `static` keyword. Instead, the caller will have to pass in a structure that will be filled by this function. Else, `pld` lives on the stack which gets destroyed on return from this function and the caller ends up referencing an invalid object.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56024
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaaf140ce1965dce3a812aa2701ce0e29b34ab3e7
Gerrit-Change-Number: 56024
Gerrit-PatchSet: 6
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Abhijeet Rao
abhijeet.rao@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Comment-Date: Thu, 08 Jul 2021 06:02:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-MessageType: comment