Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28101 )
Change subject: Makefile: Add $(xcompile) to specify where to write xcompile
......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/28101/6/src/soc/nvidia/tegra124/lp0...
File src/soc/nvidia/tegra124/lp0/Makefile:
https://review.coreboot.org/c/coreboot/+/28101/6/src/soc/nvidia/tegra124/lp0...
PS6, Line 16: xcompile
since this file doesn't respect the $(obj) variable I was hesitant to write anything into the src di […]
I want to leave the build cleanup for another day.
https://review.coreboot.org/c/coreboot/+/28101/6/util/testing/Makefile.inc
File util/testing/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/28101/6/util/testing/Makefile.inc@9...
PS6, Line 94:
If the nvidia makefiles create .xcompile on their own, this is not needed.
Same
--
To view, visit
https://review.coreboot.org/c/coreboot/+/28101
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia83f234447b977efa824751c9674154b77d606b0
Gerrit-Change-Number: 28101
Gerrit-PatchSet: 11
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Raul Rangel
rrangel@google.com
Gerrit-Comment-Date: Fri, 04 Dec 2020 22:27:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment