Change in coreboot[master]: superio/winbond/w83977tf: Fix iasl warning

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Keith Hui (Code Review)

6 May 2020 6 May '20

10:18 a.m.

Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41095 )

Change subject: superio/winbond/w83977tf: Fix iasl warning ......................................................................

superio/winbond/w83977tf: Fix iasl warning

The common PnP serial port DSDT code is intentionally included twice for two serial ports with different LDNs. Undefine LDN and the PM register name before redefining for second serial port so iasl doesn't complain.

Change-Id: I031905479c66698fb01da028e3f37d923396d2d9 Signed-off-by: Keith Hui buurin@gmail.com --- M src/superio/winbond/w83977tf/acpi/superio.asl 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/41095/1

diff --git a/src/superio/winbond/w83977tf/acpi/superio.asl b/src/superio/winbond/w83977tf/acpi/superio.asl index 918d1e1..9b4a212 100644 --- a/src/superio/winbond/w83977tf/acpi/superio.asl +++ b/src/superio/winbond/w83977tf/acpi/superio.asl @@ -351,6 +351,8 @@ #define SUPERIO_UART_LDN W83977TF_SP1 #define SUPERIO_UART_PM_REG UAPW #include <superio/acpi/pnp_uart.asl> + #undef SUPERIO_UART_LDN + #undef SUPERIO_UART_PM_REG #endif

#ifdef SUPERIO_SHOW_UARTB

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Angel Pons (Code Review)

11 May 11 May

2:20 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41095 )

Change subject: superio/winbond/w83977tf: Fix iasl warning ......................................................................

Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/41095/2/src/superio/winbond/w83977t... File src/superio/winbond/w83977tf/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/41095/2/src/superio/winbond/w83977t... PS2, Line 358: #ifdef SUPERIO_SHOW_UARTB Maybe undefine it here instead?

-- To view, visit https://review.coreboot.org/c/coreboot/+/41095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I031905479c66698fb01da028e3f37d923396d2d9 Gerrit-Change-Number: 41095 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 11 May 2020 08:20:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

19 May 19 May

2:05 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41095 )

Change subject: superio/winbond/w83977tf: Fix iasl warning ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41095/2/src/superio/winbond/w83977t... File src/superio/winbond/w83977tf/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/41095/2/src/superio/winbond/w83977t... PS2, Line 358: #ifdef SUPERIO_SHOW_UARTB

...

Maybe undefine it here instead?

I'd rather add another set of undefines after the include in line 361 to ensure that nobody else comes to depend on these symbols.

Oh, look! A wild commit appeared: CB:41530

-- To view, visit https://review.coreboot.org/c/coreboot/+/41095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I031905479c66698fb01da028e3f37d923396d2d9 Gerrit-Change-Number: 41095 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 19 May 2020 08:05:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

2:06 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41095 )

Change subject: superio/winbond/w83977tf: Fix iasl warning ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I031905479c66698fb01da028e3f37d923396d2d9 Gerrit-Change-Number: 41095 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 19 May 2020 08:06:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

2:06 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41095 )

Change subject: superio/winbond/w83977tf: Fix iasl warning ......................................................................

superio/winbond/w83977tf: Fix iasl warning

Change-Id: I031905479c66698fb01da028e3f37d923396d2d9 Signed-off-by: Keith Hui buurin@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41095 Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/superio/winbond/w83977tf/acpi/superio.asl 1 file changed, 2 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve

diff --git a/src/superio/winbond/w83977tf/acpi/superio.asl b/src/superio/winbond/w83977tf/acpi/superio.asl index cd514d0..6e37a5b 100644 --- a/src/superio/winbond/w83977tf/acpi/superio.asl +++ b/src/superio/winbond/w83977tf/acpi/superio.asl @@ -350,6 +350,8 @@ #define SUPERIO_UART_LDN W83977TF_SP1 #define SUPERIO_UART_PM_REG UAPW #include <superio/acpi/pnp_uart.asl> + #undef SUPERIO_UART_LDN + #undef SUPERIO_UART_PM_REG #endif

#ifdef SUPERIO_SHOW_UARTB

-- To view, visit https://review.coreboot.org/c/coreboot/+/41095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I031905479c66698fb01da028e3f37d923396d2d9 Gerrit-Change-Number: 41095 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

2:46 a.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41095 )

Change subject: superio/winbond/w83977tf: Fix iasl warning ......................................................................

Patch Set 4:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3556 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3555 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3554 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3553

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/41095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I031905479c66698fb01da028e3f37d923396d2d9 Gerrit-Change-Number: 41095 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 19 May 2020 08:46:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1822

days inactive

1835

days old

coreboot-gerrit@coreboot.org

5 comments

4 participants

tags (0)

participants (4)

9elements QA (Code Review)
Angel Pons (Code Review)
Keith Hui (Code Review)
Patrick Georgi (Code Review)