build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27746 )
Change subject: soc/intel/apollolake: Force USB-C into host mode ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/27746/1/src/soc/intel/apollolake/chip.c File src/soc/intel/apollolake/chip.c:
https://review.coreboot.org/#/c/27746/1/src/soc/intel/apollolake/chip.c@673 PS1, Line 673: * When USB OTG is set, GLK FSP enables xHCI SW ID pin and configures line over 80 characters
https://review.coreboot.org/#/c/27746/1/src/soc/intel/apollolake/chip.c@676 PS1, Line 676: if (IS_ENABLED(CONFIG_SOC_INTEL_GLK) && vboot_can_enable_udc()) { line over 80 characters
https://review.coreboot.org/#/c/27746/1/src/soc/intel/apollolake/chip.c@697 PS1, Line 697: while ((read32(cfg1) & DRD_MODE_MASK) != DRD_MODE_HOST) { line over 80 characters