Attention is currently required from: David Wu, Dinesh Gehlot, Jayvik Desai, Nick Vaccaro.
Paul Menzel has posted comments on this change by David Wu. ( https://review.coreboot.org/c/coreboot/+/87232?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/nissa/var/dirks: Enable ASPM of RTL8111H
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87232/comment/1d2002e6_2ff171bc?usp... :
PS2, Line 9: Because the NIC does not enter ASPM L1.2.
… because it’s disabled in the baseboard?
https://review.coreboot.org/c/coreboot/+/87232/comment/4101a009_a397b2a6?usp... :
PS2, Line 13: TEST=emerge and test with command powerd_dbus_suspend
Please paste the relevant output of the command.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87232?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0e4f0a4aba736811f3b803f4a1245a635ec59407
Gerrit-Change-Number: 87232
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Sat, 12 Apr 2025 19:36:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No