Attention is currently required from: Nico Huber, Krishna Prabhakaran, Furquan Shaikh, Maulik V Vaghela, Selma Bensaid, Meera Ravindranath, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52758 )
Change subject: drivers/intel/gma: Support IGD Opregion 2.1 ......................................................................
Patch Set 13:
(3 comments)
File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/52758/comment/9c8d909a_a1409a20 PS13, Line 105: INTEL_GMA_OPREGION_2_0
I believe that we would need support for 2. […]
I would recommend to make 2.0 as default for now looking at backward platforms and i believe the GFX driver would have different expectations based on opregion being filled.
And let SoC user selects 2_1 and later if we are migrating to latest spec, then it would be easy for SoC user to select that too ?
May be for now majority of platform do support 2_0 hence making 2_1 default would need to go and select 2_0 from respective Kconfig would be too much isn't it ?
File src/drivers/intel/gma/opregion.c:
https://review.coreboot.org/c/coreboot/+/52758/comment/acbb6b0c_7259ac7a PS13, Line 277: knowing that we have only 2_1 and 2_0. "return dead_code_t(u32);" is never posisble isn't it as you have made 2_0 always default ?
can we just check one and default return value that applicable for 2_0?
static u32 opregion_version(void) { if (CONFIG(INTEL_GMA_OPREGION_2_1)) return 0x201;
return 0x200; }
https://review.coreboot.org/c/coreboot/+/52758/comment/d9fd64e4_ab9a159b PS13, Line 294: if (CONFIG(INTEL_GMA_OPREGION_2_0)) i would say, check for 2_1 and return the default for 2_0, in that way we can keep placeholder for Opregion 3.0 in future ?
-
Subrata Banik (Code Review)