Attention is currently required from: Subrata Banik.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74377 )
Change subject: soc/intel/cannonlake: Allow SoC to choose CAR mode (eNEM/NEM) ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Is there some document to tell on which platforms this can be done?
typically all client skus like CML and WHL that chromeos team worked has eNEM enabled.
We never worked on any desktop platform like CFL hence, i assume eNEM never tested there.
Makes sense. It would be good to include the reasoning of https://review.coreboot.org/c/coreboot/+/74376 inside either the commit message or as a comment so that the git history has the reasoning included.