Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62645 )
Change subject: soc/intel/adl/chip.h: Convert all camel case variables to snake case ......................................................................
Patch Set 3: Code-Review+1
(5 comments)
File src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/62645/comment/a87834b5_abd9f670 PS3, Line 76: can you please align this tab too ?
File src/mainboard/google/brya/variants/brya4es/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62645/comment/4300150d_41af5d0d PS3, Line 38: SaGv Did you miss this ?
File src/mainboard/google/brya/variants/gimble/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62645/comment/ae82dfbf_b25c3b2b PS3, Line 24: SaGv same
File src/mainboard/google/brya/variants/taniks/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62645/comment/0ec0965a_284595c0 PS3, Line 54: SaGv same
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/62645/comment/95a5d752_a31306d5 PS3, Line 230: SaGv please fix this as well