Change in ...libgfxinit[master]: gma pipe setup: Fix secondary pipe cursors <= Sandy Bridge - coreboot-gerrit

17 Jun 2019


      Reto Buerki has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/27154 )
Change subject: gma pipe setup: Fix secondary pipe cursors <= Sandy Bridge
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/27154/3/common/hw-gfx-gma-pipe_setup.ads 
File common/hw-gfx-gma-pipe_setup.ads:
https://review.coreboot.org/#/c/27154/3/common/hw-gfx-gma-pipe_setup.ads@244 
PS3, Line 244:       FBC_CTL  : Registers.Registers_Invalid_Index;
...
Everything is aligned to a multiple of 3 here. I don't have a written […]
Ah ic, I did not know that it is aligned to a multiple of 3. I'm not aware of an internal style guide which applies here.
-- 
To view, visit https://review.coreboot.org/c/libgfxinit/+/27154
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: I4d79f59a8cb693d73d6da666525f091021efb4fd
Gerrit-Change-Number: 27154
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Adrian-Ken Rueegsegger ken@codelabs.ch
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Reto Buerki reet@codelabs.ch
Gerrit-Comment-Date: Mon, 17 Jun 2019 13:29:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Reto Buerki reet@codelabs.ch
Gerrit-MessageType: comment