Change in coreboot[master]: tint: introduce the new tint build system with checksum verification
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23856 )
Change subject: tint: introduce the new tint build system with checksum verification ......................................................................
Patch Set 4:
(12 comments)
https://review.coreboot.org/#/c/23856/4/payloads/external/tint/generate_core... File payloads/external/tint/generate_core.sh:
https://review.coreboot.org/#/c/23856/4/payloads/external/tint/generate_core... PS4, Line 38: sed -n "/^${start}/,/^${end}/{/^${start}/{p;n};{p}}" $source >> $destination line over 80 characters
https://review.coreboot.org/#/c/23856/4/payloads/external/tint/generate_core... PS4, Line 40: sed -n "/^${start}/,/^${end}/{/^${start}/{p;n};/^${end}/{q};{p}}" $source >> $destination line over 80 characters
https://review.coreboot.org/#/c/23856/4/payloads/external/tint/generate_core... PS4, Line 54: FUNCTIONS="please_install searchtool download compute_hash error_hash_mismatch verify_hash unpack_and_patch" line over 80 characters
https://review.coreboot.org/#/c/23856/4/payloads/external/tint/generate_core... PS4, Line 64: import_from_file $buildgcc $corescript "# Find all the required tools" "# Allow" last_line_disabled || exit "$?" line over 80 characters
https://review.coreboot.org/#/c/23856/4/payloads/external/tint/generate_core... PS4, Line 70: import_from_file $buildgcc $corescript "if [ "$HALT_FOR_TOOLS" "fi" || exit "$?" line over 80 characters
https://review.coreboot.org/#/c/23856/4/payloads/external/tint/generate_core... PS4, Line 86: sed -i -e "s/\tknown_hash="$(get_known_hash.*/\tknown_hash="$2"/g" $corescript line over 80 characters
https://review.coreboot.org/#/c/23856/4/payloads/external/tint/generate_core... PS4, Line 95: # Insert prepare_${package} function call between the unpack and patch operations line over 80 characters
https://review.coreboot.org/#/c/23856/4/payloads/external/tint/generate_core... PS4, Line 99: sed -i -e "/$TAR $FLAGS $(basename $archive)/a prepare_${package} || exit "$?"" $corescript line over 80 characters
https://review.coreboot.org/#/c/23856/4/payloads/external/tint/tintify_core.... File payloads/external/tint/tintify_core.sh:
https://review.coreboot.org/#/c/23856/4/payloads/external/tint/tintify_core.... PS4, Line 42: echo "if [ ! -z ./${TINT_DIR} ] && [ -e ./${TINT_DIR}/debian ]; then" >> $tintified line over 80 characters
https://review.coreboot.org/#/c/23856/4/payloads/external/tint/tintify_core.... PS4, Line 43: echo "rm -rf ./${TINT_DIR}/debian ./${TINT_DIR}/typedefs.h ./${TINT_DIR}/Makefile;" >> $tintified line over 80 characters
https://review.coreboot.org/#/c/23856/4/payloads/external/tint/tintify_core.... PS4, Line 61: echo "printf "Downloaded TINT tarball ... ${green}ok${NC}\n"" >> ${tintified} line over 80 characters
https://review.coreboot.org/#/c/23856/4/payloads/external/tint/tintify_core.... PS4, Line 65: echo "printf "Unpacked and patched TINT... ${green}ok${NC}\n"" >> ${tintified} line over 80 characters
-
build bot (Jenkins) (Code Review)