Change in coreboot[master]: include/console: Fix FSP Notify phase postcodes discrepancy

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52894 )

Change subject: include/console: Fix FSP Notify phase postcodes discrepancy
......................................................................

include/console: Fix FSP Notify phase postcodes discrepancy

List of changes:
1. Make the FSP notify phases name prior in comments section.
2. Fix discrepancies in FSP notify before and after postcode comments.
3. Add FSP notify postcode macros for after pci enumeration(0xa2)
and ready to boot(0xa3) call.

Change-Id: Ib4c825d5f1f31f80ad2a03ff5d6006daa7104d23
Signed-off-by: Subrata Banik 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52894
Reviewed-by: Furquan Shaikh 
Reviewed-by: Marshall Dawson 
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/drivers/intel/fsp2_0/notify.c
M src/include/console/post_codes.h
2 files changed, 24 insertions(+), 10 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Marshall Dawson: Looks good to me, approved
  Angel Pons: Looks good to me, but someone else must approve

diff --git a/src/drivers/intel/fsp2_0/notify.c b/src/drivers/intel/fsp2_0/notify.c
index cbccc6e..311ce46 100644
--- a/src/drivers/intel/fsp2_0/notify.c
+++ b/src/drivers/intel/fsp2_0/notify.c
@@ -38,10 +38,10 @@

if (phase == AFTER_PCI_ENUM) {
    	timestamp_add_now(TS_FSP_AFTER_ENUMERATE);
-		post_code(POST_FSP_NOTIFY_BEFORE_ENUMERATE);
+		post_code(POST_FSP_NOTIFY_AFTER_ENUMERATE);
    } else if (phase == READY_TO_BOOT) {
    	timestamp_add_now(TS_FSP_AFTER_FINALIZE);
-		post_code(POST_FSP_NOTIFY_BEFORE_FINALIZE);
+		post_code(POST_FSP_NOTIFY_AFTER_FINALIZE);
    } else if (phase == END_OF_FIRMWARE) {
    	timestamp_add_now(TS_FSP_AFTER_END_OF_FIRMWARE);
    	post_code(POST_FSP_NOTIFY_AFTER_END_OF_FIRMWARE);
diff --git a/src/include/console/post_codes.h b/src/include/console/post_codes.h
index 9b2398c..10793e3 100644
--- a/src/include/console/post_codes.h
+++ b/src/include/console/post_codes.h
@@ -204,16 +204,16 @@
 #define POST_BS_PAYLOAD_BOOT			0x7b

/**
- * \brief Before calling FSP Notify before End of Firmware
+ * \brief Before calling FSP Notify (end of firmware)
  *
- * Going to call into FSP binary for Notify phase
+ * Going to call into FSP binary for Notify phase (end of firmware)
  */
 #define POST_FSP_NOTIFY_BEFORE_END_OF_FIRMWARE	0x88

/**
- * \brief Before calling FSP Notify after End of Firmware
+ * \brief After calling FSP Notify (end of firmware)
  *
- * Going to call into FSP binary for Notify phase
+ * Going to call into FSP binary for Notify phase (end of firmware)
  */
 #define POST_FSP_NOTIFY_AFTER_END_OF_FIRMWARE	0x89

@@ -246,16 +246,16 @@
 #define POST_FSP_SILICON_INIT			0x93

/**
- * \brief Before calling FSP Notify before resource allocation
+ * \brief Before calling FSP Notify (after PCI enumeration)
  *
- * Going to call into FSP binary for Notify phase
+ * Going to call into FSP binary for Notify phase (after PCI enumeration)
  */
 #define POST_FSP_NOTIFY_BEFORE_ENUMERATE	0x94

/**
- * \brief Before calling FSP Notify before finalize
+ * \brief Before calling FSP Notify (ready to boot)
  *
- * Going to call into FSP binary for Notify phase
+ * Going to call into FSP binary for Notify phase (ready to boot)
  */
 #define POST_FSP_NOTIFY_BEFORE_FINALIZE		0x95

@@ -302,6 +302,20 @@
 #define POST_FSP_MULTI_PHASE_SI_INIT_EXIT	0xa1

/**
+ * \brief After calling FSP Notify (after PCI enumeration)
+ *
+ * Going to call into FSP binary for Notify phase (after PCI enumeration)
+ */
+#define POST_FSP_NOTIFY_AFTER_ENUMERATE        0xa2
+
+/**
+ * \brief After calling FSP Notify (ready to boot)
+ *
+ * Going to call into FSP binary for Notify phase (ready to boot)
+ */
+#define POST_FSP_NOTIFY_AFTER_FINALIZE         0xa3
+
+/**
  * \brief Invalid or corrupt ROM
  *
  * Set if firmware failed to find or validate a resource that is stored in ROM.