Change in coreboot[master]: AGESA: Disable CBMEM_STAGE_CACHE by default

List overview All Threads
Download

newer

older

Change in coreboot[master]: vboot:...

Change in coreboot[master]: src:...

Kyösti Mälkki (Code Review)

12 Dec 2019 12 Dec '19

10:32 p.m.

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37684 )

Change subject: AGESA: Disable CBMEM_STAGE_CACHE by default ......................................................................

AGESA: Disable CBMEM_STAGE_CACHE by default

To have functional ACPI S3 resume no longer requires this.

Change-Id: Ib7d5e8b960418dc7d466cdfe46724ac68001dd00 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/cpu/amd/agesa/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/37684/1

diff --git a/src/cpu/amd/agesa/Kconfig b/src/cpu/amd/agesa/Kconfig index 2c8f9c5..fae2565 100644 --- a/src/cpu/amd/agesa/Kconfig +++ b/src/cpu/amd/agesa/Kconfig @@ -26,7 +26,6 @@ select UDELAY_LAPIC select LAPIC_MONOTONIC_TIMER select SPI_FLASH if HAVE_ACPI_RESUME - select CBMEM_STAGE_CACHE if HAVE_ACPI_RESUME select SMM_ASEG select NO_FIXED_XIP_ROM_SIZE select SSE2

Attachments:

attachment.htm (text/html — 2.3 KB)

Show replies by date

Marshall Dawson (Code Review)

13 Dec 13 Dec

7:35 p.m.

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37684 )

Change subject: AGESA: Disable CBMEM_STAGE_CACHE by default ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37684/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37684/2//COMMIT_MSG@9 PS2, Line 9: To have functional ACPI S3 resume no longer requires this. Do you mean merely that a stage cache isn't used now? And if so, is it accurate a stage cache was required before?

-- To view, visit https://review.coreboot.org/c/coreboot/+/37684 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7d5e8b960418dc7d466cdfe46724ac68001dd00 Gerrit-Change-Number: 37684 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Comment-Date: Fri, 13 Dec 2019 19:35:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

7:39 p.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37684 )

Change subject: AGESA: Disable CBMEM_STAGE_CACHE by default ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37684/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37684/2//COMMIT_MSG@9 PS2, Line 9: To have functional ACPI S3 resume no longer requires this.

...

Do you mean merely that a stage cache isn't used now? And if so, is it accurate a stage cache was r […]

See CB:36708

Then again, we have followup changes from amd/stoneyridge with stage_cache_add_raw() which would again require us to select this. So I did not bother with good commit message yet :)

-- To view, visit https://review.coreboot.org/c/coreboot/+/37684 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7d5e8b960418dc7d466cdfe46724ac68001dd00 Gerrit-Change-Number: 37684 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Comment-Date: Fri, 13 Dec 2019 19:39:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-MessageType: comment

Mike Banon (Code Review)

15 Dec 15 Dec

7:53 p.m.

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37684 )

Change subject: AGESA: Disable CBMEM_STAGE_CACHE by default ......................................................................

Patch Set 2: Code-Review+1

S3 Suspend is working fine on AM1I-A with this change installed and CBMEM_STAGE_CACHE disabled at .config. G505S does not boot because of amd_iommu_init_pci Linux kernel panic - however, I know it's caused not by your change but by some unfortunate parent ( I had exactly the same problem with coreboot cloned a few days ago ). This problem didn't happen with 50b82ef2bb44602a62d676f2b9c6900da0ad4162 this morning's master, so perhaps these commit series should be rebased on top of master before I could test it again on G505S.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37684 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7d5e8b960418dc7d466cdfe46724ac68001dd00 Gerrit-Change-Number: 37684 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Comment-Date: Sun, 15 Dec 2019 19:53:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Mike Banon (Code Review)

16 Dec 16 Dec

9 a.m.

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37684 )

Change subject: AGESA: Disable CBMEM_STAGE_CACHE by default ......................................................................

Patch Set 4: Code-Review+2

S3 suspend is working great on both G505S (15h) and AM1I-A (16h) even without CBMEM_STAGE_CACHE , thanks to your good changes. I had to rebase this relation chain on top of d912df22a8fde68dc513824d757b71eb16703479 , as it's the last commit before AM1I-A removal from Kconfig, while also it's almost master.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37684 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7d5e8b960418dc7d466cdfe46724ac68001dd00 Gerrit-Change-Number: 37684 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Comment-Date: Mon, 16 Dec 2019 09:00:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Marshall Dawson (Code Review)

17 Dec 17 Dec

3:11 a.m.

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37684 )

Change subject: AGESA: Disable CBMEM_STAGE_CACHE by default ......................................................................

Patch Set 4: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/37684 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7d5e8b960418dc7d466cdfe46724ac68001dd00 Gerrit-Change-Number: 37684 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 17 Dec 2019 03:11:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

10:47 p.m.

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37684 )

Change subject: AGESA: Disable CBMEM_STAGE_CACHE by default ......................................................................

Abandoned

squashed with CB:37683

-- To view, visit https://review.coreboot.org/c/coreboot/+/37684 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7d5e8b960418dc7d466cdfe46724ac68001dd00 Gerrit-Change-Number: 37684 Gerrit-PatchSet: 5 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1749

days inactive

1754

days old

coreboot-gerrit@coreboot.org

6 comments

3 participants

tags (0)

participants (3)

Kyösti Mälkki (Code Review)
Marshall Dawson (Code Review)
Mike Banon (Code Review)