Change in coreboot[master]: soc/amd/cezanne: Turn off gpp clock request for disabled devices

[Raul Rangel (Code Review)]

Attention is currently required from: Robert Zieba, Martin Roth, Paul Menzel, Rob Barnes, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61259 )

Change subject: soc/amd/cezanne: Turn off gpp clock request for disabled devices
......................................................................

Patch Set 27:

(5 comments)

File src/soc/amd/cezanne/fch.c:

https://review.coreboot.org/c/coreboot/+/61259/comment/b8e3edc0_47834fe0 
PS27, Line 159: clk_req
Can we call this `dxio_clk_req` so I don't have to trace where it came from?

https://review.coreboot.org/c/coreboot/+/61259/comment/94115267_d9c64540 
PS27, Line 162: clk_req is only 4 bits
Nice catch

https://review.coreboot.org/c/coreboot/+/61259/comment/e75f2434_a2de8b05 
PS27, Line 176: -
Is `clk_req == CLK_DISABLE` not valid? Do we want that throwing an assert?

https://review.coreboot.org/c/coreboot/+/61259/comment/2627cc7e_a1acb508 
PS27, Line 178: assert
Just FYI, assert only dies if compiled with FATAL_ASSERT. Otherwise we just keep going...

https://review.coreboot.org/c/coreboot/+/61259/comment/1063b917_d98ed4a5 
PS27, Line 196: 			if (fw_config_probe_dev(pci_device, &probe)) {
              : 				/*
              : 				 * fw_config probes don't touch the SoC gpp_clk_config.
              : 				 * So there's only a mismatch if the device was disabled
              : 				 * by something other than a probe.
              : 				 */
              : 				printk(BIOS_WARNING,
              : 					"GPP clk req mismatch: %d.%d disabled, disabling GPP clk req %d, DXIO descriptor %d\n",
              : 					dxio_desc->device_number,
              : 					dxio_desc->function_number, gpp_req_index, i);
              : 			} else {
Part of me feels like we should just remove this whole chunk.