Change in ...coreboot[master]: soc/intel/common/uart: Correctly guard uart_platform_base()

[Nico Huber (Code Review)]

Hello Patrick Rudolph, Lance Zhao,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/33097

to review the following change.

Change subject: soc/intel/common/uart: Correctly guard uart_platform_base()
......................................................................

soc/intel/common/uart: Correctly guard uart_platform_base()

We should only provide this implementation when the Intel LPSS UART is
used. Otherwise, no other UART could be used for the console with these
SoCs.

Change-Id: Iebd89edb3f21d4a68587fd02659b4d529f3f4bbe
Signed-off-by: Nico Huber 
---
M src/soc/intel/common/block/uart/uart.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/33097/1

diff --git a/src/soc/intel/common/block/uart/uart.c b/src/soc/intel/common/block/uart/uart.c
index 47774b6..84ba1ee 100644
--- a/src/soc/intel/common/block/uart/uart.c
+++ b/src/soc/intel/common/block/uart/uart.c
@@ -43,7 +43,7 @@
    		CONFIG_SOC_INTEL_COMMON_LPSS_UART_CLK_N_VAL);
 }

-#if CONFIG(DRIVERS_UART_8250MEM)
+#if CONFIG(INTEL_LPSS_UART_FOR_CONSOLE)
 uintptr_t uart_platform_base(int idx)
 {
    if (idx == CONFIG_UART_FOR_CONSOLE)

[Lance Zhao (Code Review)]

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33097 )

Change subject: soc/intel/common/uart: Correctly guard uart_platform_base()
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33097 )

Change subject: soc/intel/common/uart: Correctly guard uart_platform_base()
......................................................................

soc/intel/common/uart: Correctly guard uart_platform_base()

We should only provide this implementation when the Intel LPSS UART is
used. Otherwise, no other UART could be used for the console with these
SoCs.

Change-Id: Iebd89edb3f21d4a68587fd02659b4d529f3f4bbe
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33097
Tested-by: build bot (Jenkins) 
Reviewed-by: Lance Zhao 
---
M src/soc/intel/common/block/uart/uart.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Lance Zhao: Looks good to me, approved

diff --git a/src/soc/intel/common/block/uart/uart.c b/src/soc/intel/common/block/uart/uart.c
index 47774b6..84ba1ee 100644
--- a/src/soc/intel/common/block/uart/uart.c
+++ b/src/soc/intel/common/block/uart/uart.c
@@ -43,7 +43,7 @@
    		CONFIG_SOC_INTEL_COMMON_LPSS_UART_CLK_N_VAL);
 }

-#if CONFIG(DRIVERS_UART_8250MEM)
+#if CONFIG(INTEL_LPSS_UART_FOR_CONSOLE)
 uintptr_t uart_platform_base(int idx)
 {
    if (idx == CONFIG_UART_FOR_CONSOLE)