Change in ...coreboot[master]: soc/intel/common/uart: Only return valid UART base

[Nico Huber (Code Review)]

Hello Patrick Rudolph, Lance Zhao,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/33096

to review the following change.

Change subject: soc/intel/common/uart: Only return valid UART base
......................................................................

soc/intel/common/uart: Only return valid UART base

We only configure the base address for the console UART, the other
addresses are never assigned to the hardware. It seems better to
return 0 for them instead of a spurious value.

Change-Id: I3fa5c99958b56ca5b0b603917c086bdddb677fa2
Signed-off-by: Nico Huber 
---
M src/soc/intel/common/block/uart/uart.c
1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/33096/1

diff --git a/src/soc/intel/common/block/uart/uart.c b/src/soc/intel/common/block/uart/uart.c
index 35c2c6c..47774b6 100644
--- a/src/soc/intel/common/block/uart/uart.c
+++ b/src/soc/intel/common/block/uart/uart.c
@@ -46,8 +46,9 @@
 #if CONFIG(DRIVERS_UART_8250MEM)
 uintptr_t uart_platform_base(int idx)
 {
-	/* return Base address for UART console index */
-	return UART_BASE_0_ADDR(idx);
+	if (idx == CONFIG_UART_FOR_CONSOLE)
+		return UART_BASE_0_ADDR(CONFIG_UART_FOR_CONSOLE);
+	return 0;
 }
 #endif

[Lance Zhao (Code Review)]

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33096 )

Change subject: soc/intel/common/uart: Only return valid UART base
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33096 )

Change subject: soc/intel/common/uart: Only return valid UART base
......................................................................

soc/intel/common/uart: Only return valid UART base

We only configure the base address for the console UART, the other
addresses are never assigned to the hardware. It seems better to
return 0 for them instead of a spurious value.

Change-Id: I3fa5c99958b56ca5b0b603917c086bdddb677fa2
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33096
Tested-by: build bot (Jenkins) 
Reviewed-by: Lance Zhao 
---
M src/soc/intel/common/block/uart/uart.c
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Lance Zhao: Looks good to me, approved

diff --git a/src/soc/intel/common/block/uart/uart.c b/src/soc/intel/common/block/uart/uart.c
index 35c2c6c..47774b6 100644
--- a/src/soc/intel/common/block/uart/uart.c
+++ b/src/soc/intel/common/block/uart/uart.c
@@ -46,8 +46,9 @@
 #if CONFIG(DRIVERS_UART_8250MEM)
 uintptr_t uart_platform_base(int idx)
 {
-	/* return Base address for UART console index */
-	return UART_BASE_0_ADDR(idx);
+	if (idx == CONFIG_UART_FOR_CONSOLE)
+		return UART_BASE_0_ADDR(CONFIG_UART_FOR_CONSOLE);
+	return 0;
 }
 #endif