Attention is currently required from: YH Lin, Tim Wawrzynczak, Raihow Shi, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63604 )
Change subject: mb/google/brask/variants/moli: use specific VBT files for moli
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63604/comment/18faafd4_ade4a08e
PS2, Line 7: for moli
Remove as already in prefix.
https://review.coreboot.org/c/coreboot/+/63604/comment/02308804_e1f85e81
PS2, Line 10: and return different vbt.bin
Maybe:
Use specific VBTs for HDMI, DP, and ABSENT according to FW_CONFIG.
File src/mainboard/google/brya/variants/moli/ramstage.c:
https://review.coreboot.org/c/coreboot/+/63604/comment/013279cc_543e9cd7
PS2, Line 38: return "vbt-moli_HDMI.bin";
Where are these VBTs?
https://review.coreboot.org/c/coreboot/+/63604/comment/1328dbb6_c1ca3604
PS2, Line 39: else if (fw_config_probe(FW_CONFIG(DB_OPT, OPT_HDMI)))
Same condition? Should be DP?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63604
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc8fbef1467605505459fce264697f670591c81e
Gerrit-Change-Number: 63604
Gerrit-PatchSet: 2
Gerrit-Owner: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 13 Apr 2022 08:20:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment