Attention is currently required from: Paul Menzel, Angel Pons, Arthur Heymans.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64094 )
Change subject: nb/intel/gm45: Allow for PCI BARs above 4G
......................................................................
Patch Set 3:
(1 comment)
File src/northbridge/intel/gm45/northbridge.c:
https://review.coreboot.org/c/coreboot/+/64094/comment/b8c4d87e_60459e7e
PS3, Line 189: const uint64_t touud = get_touud();
Even without the reclaiming of memory below 4G, the hardware doesn't map the ME stolen memory for th […]
My concern was more what happens when the ME tries to access its memory
(in case that is mapped 1:1). Technically, its request would pass buses
where another device could positively decode the addresses.
Any UMA device could have that issue, in theory. But GFX, for instance,
is integrated much closer to the DRAM controller. I guess it doesn't
pass any PCI bus.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64094
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62a8a656481eba01add3d7d06b42e3352206df1b
Gerrit-Change-Number: 64094
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 09 May 2022 23:18:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment