Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52808 )
Change subject: soc/intel/*: Update data types for variables holding PCH_DEVFN_* macros ......................................................................
soc/intel/*: Update data types for variables holding PCH_DEVFN_* macros
The usage of `pci_devfn_t` here is misleading, as these intentionally store the `PCH_DEVFN_*` macros so they can be used across `smm` and `ramstage` without requiring the device model. Update to `unsigned int` instead, as `pci_devfn_t` implies the data is an MMCONF-compatible PCI devfn offset.
Change-Id: Ic8880de984e6eceda4cbe141e118f3a5fdd672a2 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/soc/intel/alderlake/elog.c M src/soc/intel/jasperlake/elog.c M src/soc/intel/skylake/elog.c M src/soc/intel/tigerlake/elog.c 4 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/52808/1
diff --git a/src/soc/intel/alderlake/elog.c b/src/soc/intel/alderlake/elog.c index 84765d9..7b0fd87 100644 --- a/src/soc/intel/alderlake/elog.c +++ b/src/soc/intel/alderlake/elog.c @@ -12,7 +12,7 @@ #include <types.h>
struct pme_map { - pci_devfn_t devfn; + unsigned int devfn; unsigned int wake_source; };
diff --git a/src/soc/intel/jasperlake/elog.c b/src/soc/intel/jasperlake/elog.c index 858b371..61b8fb8 100644 --- a/src/soc/intel/jasperlake/elog.c +++ b/src/soc/intel/jasperlake/elog.c @@ -12,7 +12,7 @@ #include <types.h>
struct pme_map { - pci_devfn_t devfn; + unsigned int devfn; unsigned int wake_source; };
diff --git a/src/soc/intel/skylake/elog.c b/src/soc/intel/skylake/elog.c index c6be670..1c80517 100644 --- a/src/soc/intel/skylake/elog.c +++ b/src/soc/intel/skylake/elog.c @@ -26,7 +26,7 @@ }
struct pme_status_info { - pci_devfn_t devfn; + unsigned int devfn; uint8_t reg_offset; uint32_t elog_event; }; diff --git a/src/soc/intel/tigerlake/elog.c b/src/soc/intel/tigerlake/elog.c index 0fccf84..93174be 100644 --- a/src/soc/intel/tigerlake/elog.c +++ b/src/soc/intel/tigerlake/elog.c @@ -12,7 +12,7 @@ #include <types.h>
struct pme_map { - pci_devfn_t devfn; + unsigned int devfn; unsigned int wake_source; };